preview2

.gitignore

@@ -155,3 +155,5 @@ src/UniTask/UniTask.Editor.csproj
 src/UniTask/UniTask.Tests.csproj
 
 src/UniTask/UniTask.Tests.Editor.csproj
+
+src/UniTask/UniTask.unitypackage

src/UniTask/Assets/Plugins/UniTask/Triggers/AsyncTriggerBase.cs

@@ -212,11 +212,16 @@ namespace Cysharp.Threading.Tasks.Triggers
         // optimize: many cases, handler is single.
         AsyncTriggerHandler<T> singleHandler;
 
-        List<AsyncTriggerHandler<T>> handlers;
+        AsyncTriggerHandler<T>[] handlers;
+
+        // when running(in TrySetResult), does not add immediately.
+        bool isRunning;
+        AsyncTriggerHandler<T> waitHandler;
+        MinimumQueue<AsyncTriggerHandler<T>> waitQueue;
 
         public bool TrySetResult(T value)
         {
-            List<Exception> exceptions = null;
+            isRunning = true;
 
             if (singleHandler != null)
             {
@@ -226,56 +231,44 @@ namespace Cysharp.Threading.Tasks.Triggers
                 }
                 catch (Exception ex)
                 {
-                    if (handlers == null)
-                    {
-                        throw;
-                    }
-                    else
-                    {
-                        exceptions = new List<Exception>();
-                        exceptions.Add(ex);
-                    }
+                    Debug.LogException(ex);
                 }
             }
 
             if (handlers != null)
             {
-                // make snapshot
-                var rentArray = ArrayPoolUtil.CopyToRentArray(handlers);
-                var clearArray = true;
-                try
+                for (int i = 0; i < handlers.Length; i++)
                 {
-                    var array = rentArray.Array;
-                    var len = rentArray.Length;
-                    for (int i = 0; i < len; i++)
+                    if (handlers[i] != null)
                     {
                         try
                         {
-                            ((IResolvePromise<T>)array[i]).TrySetResult(value);
+                            ((IResolvePromise<T>)handlers[i]).TrySetResult(value);
                         }
                         catch (Exception ex)
                         {
-                            if (exceptions == null)
-                            {
-                                exceptions = new List<Exception>();
-                            }
-                            exceptions.Add(ex);
-                        }
-                        finally
-                        {
-                            array[i] = null;
+                            handlers[i] = null;
+                            Debug.LogException(ex);
                         }
                     }
                 }
-                finally
-                {
-                    rentArray.DisposeManually(clearArray);
-                }
             }
 
-            if (exceptions != null)
+            isRunning = false;
+
+            if (waitHandler != null)
             {
-                throw new AggregateException(exceptions);
+                var h = waitHandler;
+                waitHandler = null;
+                Add(h);
+            }
+
+            if (waitQueue != null)
+            {
+                while (waitQueue.Count != 0)
+                {
+                    Add(waitQueue.Dequeue());
+                }
             }
 
             return true;
@@ -283,7 +276,7 @@ namespace Cysharp.Threading.Tasks.Triggers
 
         public bool TrySetCanceled(CancellationToken cancellationToken)
         {
-            List<Exception> exceptions = null;
+            isRunning = true;
 
             if (singleHandler != null)
             {
@@ -293,56 +286,44 @@ namespace Cysharp.Threading.Tasks.Triggers
                 }
                 catch (Exception ex)
                 {
-                    if (handlers == null)
-                    {
-                        throw;
-                    }
-                    else
-                    {
-                        exceptions = new List<Exception>();
-                        exceptions.Add(ex);
-                    }
+                    Debug.LogException(ex);
                 }
             }
 
             if (handlers != null)
             {
-                // make snapshot
-                var rentArray = ArrayPoolUtil.CopyToRentArray(handlers);
-                var clearArray = true;
-                try
+                for (int i = 0; i < handlers.Length; i++)
                 {
-                    var array = rentArray.Array;
-                    var len = rentArray.Length;
-                    for (int i = 0; i < len; i++)
+                    if (handlers[i] != null)
                     {
                         try
                         {
-                            ((ICancelPromise)array[i]).TrySetCanceled(cancellationToken);
+                            ((ICancelPromise)handlers[i]).TrySetCanceled(cancellationToken);
                         }
                         catch (Exception ex)
                         {
-                            if (exceptions == null)
-                            {
-                                exceptions = new List<Exception>();
-                            }
-                            exceptions.Add(ex);
-                        }
-                        finally
-                        {
-                            array[i] = null;
+                            Debug.LogException(ex);
+                            handlers[i] = null;
                         }
                     }
                 }
-                finally
-                {
-                    rentArray.DisposeManually(clearArray);
-                }
             }
 
-            if (exceptions != null)
+            isRunning = false;
+
+            if (waitHandler != null)
             {
-                throw new AggregateException(exceptions);
+                var h = waitHandler;
+                waitHandler = null;
+                Add(h);
+            }
+
+            if (waitQueue != null)
+            {
+                while (waitQueue.Count != 0)
+                {
+                    Add(waitQueue.Dequeue());
+                }
             }
 
             return true;
@@ -350,6 +331,22 @@ namespace Cysharp.Threading.Tasks.Triggers
 
         public void Add(AsyncTriggerHandler<T> handler)
         {
+            if (isRunning)
+            {
+                if (waitHandler == null)
+                {
+                    waitHandler = handler;
+                    return;
+                }
+
+                if (waitQueue == null)
+                {
+                    waitQueue = new MinimumQueue<AsyncTriggerHandler<T>>(4);
+                }
+                waitQueue.Enqueue(handler);
+                return;
+            }
+
             if (singleHandler == null)
             {
                 singleHandler = handler;
@@ -358,12 +355,36 @@ namespace Cysharp.Threading.Tasks.Triggers
             {
                 if (handlers == null)
                 {
-                    handlers = new List<AsyncTriggerHandler<T>>();
+                    handlers = new AsyncTriggerHandler<T>[4];
+                }
+
+                // check empty
+                for (int i = 0; i < handlers.Length; i++)
+                {
+                    if (handlers[i] == null)
+                    {
+                        handlers[i] = handler;
+                        return;
+                    }
+                }
+
+                // full, ensure capacity
+                var last = handlers.Length;
+                {
+                    EnsureCapacity(ref handlers);
+                    handlers[last] = handler;
                 }
-                handlers.Add(handler);
             }
         }
 
+        static void EnsureCapacity(ref AsyncTriggerHandler<T>[] array)
+        {
+            var newSize = array.Length * 2;
+            var newArray = new AsyncTriggerHandler<T>[newSize];
+            Array.Copy(array, 0, newArray, 0, array.Length);
+            array = newArray;
+        }
+
         public void Remove(AsyncTriggerHandler<T> handler)
         {
             if (singleHandler == handler)
@@ -374,7 +395,15 @@ namespace Cysharp.Threading.Tasks.Triggers
             {
                 if (handlers != null)
                 {
-                    handlers.Remove(handler);
+                    for (int i = 0; i < handlers.Length; i++)
+                    {
+                        if (handlers[i] == handler)
+                        {
+                            // fill null.
+                            handlers[i] = null;
+                            return;
+                        }
+                    }
                 }
             }
         }

src/UniTask/Assets/Plugins/UniTask/UniTask.cs

@@ -406,6 +406,11 @@ namespace Cysharp.Threading.Tasks
             return new UniTask(this.source, this.token);
         }
 
+        public static implicit operator UniTask(UniTask<T> self)
+        {
+            return self.AsUniTask();
+        }
+
         /// <summary>
         /// returns (bool IsCanceled, T Result) instead of throws OperationCanceledException.
         /// </summary>

src/UniTask/Assets/Plugins/UniTask/package.json

@@ -1,7 +1,7 @@
 {
     "name": "com.cysharp.unitask",
     "displayName": "UniTask",
-    "version": "1.3.1",
+    "version": "2.0.1-preview2",
     "unity": "2018.3",
     "description": "Provides an efficient async/await integration to Unity.",
     "keywords": ["async/await", "async", "Task", "UniTask"],

src/UniTask/Assets/Scenes/SandboxMain.cs

@@ -124,14 +124,19 @@ public class SandboxMain : MonoBehaviour
         CancellationTokenSource cts = new CancellationTokenSource();
 
         var trigger = this.GetAsyncUpdateTrigger();
-        Go(trigger, cts.Token).Forget();
-        //Go(trigger).Forget();
-        //Go(trigger).Forget();
+        Go(trigger, 1, cts.Token).Forget();
+        Go(trigger, 2, cts.Token).Forget();
+        Go(trigger, 3, cts.Token).Forget();
+        Go(trigger, 4, cts.Token).Forget();
+        Go(trigger, 5, cts.Token).Forget();
 
 
         Application.logMessageReceived += Application_logMessageReceived;
 
 
+        UniTask<int> foo = UniTask.FromResult(10);
+        Foo(foo);
+
         //ucs = new UniTaskCompletionSource();
 
         //okButton.onClick.AddListener(async () =>
@@ -141,7 +146,7 @@ public class SandboxMain : MonoBehaviour
 
         okButton.onClick.AddListener(() =>
         {
-            FooAsync().Forget();
+            // FooAsync().Forget();
         });
 
         cancelButton.onClick.AddListener(() =>
@@ -154,7 +159,11 @@ public class SandboxMain : MonoBehaviour
         });
     }
 
-    async UniTaskVoid Go(AsyncUpdateTrigger trigger, CancellationToken ct)
+    static void Foo(UniTask t)
+    {
+    }
+
+    async UniTaskVoid Go(AsyncUpdateTrigger trigger, int i, CancellationToken ct)
     {
         await UniTask.Yield(PlayerLoopTiming.LastPostLateUpdate);
         UnityEngine.Debug.Log("AWAIT BEFO:" + Time.frameCount);
@@ -162,14 +171,16 @@ public class SandboxMain : MonoBehaviour
 
         try
         {
-            while (true)
+            while (!ct.IsCancellationRequested)
             {
                 await handler.UpdateAsync();
+                //await handler.UpdateAsync();
+                Debug.Log("OK:" + i);
             }
         }
         finally
         {
-            UnityEngine.Debug.Log("AWAIT END:" + Time.frameCount);
+            UnityEngine.Debug.Log("AWAIT END:" + Time.frameCount + ": No," + i);
         }
     }