feat: Update package.json to 2.3.1

Fix exceptions never being reported when UniTask is executed without await and Forget()

.github/workflows/build-debug.yml

@@ -19,9 +19,6 @@ jobs:
       NUGET_XMLDOC_MODE: skip
     steps:
       - uses: actions/checkout@v2
-      - uses: actions/setup-dotnet@v1
-        with:
-          dotnet-version: 3.1.x
       - run: dotnet test -c Debug ./src/UniTask.NetCoreTests/UniTask.NetCoreTests.csproj
 
   build-unity:

.github/workflows/build-release.yml

@@ -15,7 +15,6 @@ env:
   GIT_TAG: ${{ github.event.inputs.tag }}
   DRY_RUN: ${{ github.event.inputs.dry_run }}
   DRY_RUN_BRANCH_PREFIX: "test_release"
-  DOTNET_SDK_VERISON_3: 3.1.x
 
 jobs:
   update-packagejson:
@@ -85,9 +84,6 @@ jobs:
       - uses: actions/checkout@v2
         with:
           ref: ${{ needs.update-packagejson.outputs.sha }}
-      - uses: actions/setup-dotnet@v1
-        with:
-          dotnet-version: "${{ env.DOTNET_SDK_VERSION_3 }}"
       # build and pack
       - run: dotnet build -c Release -p:Version=${{ env.GIT_TAG }}
       - run: dotnet test -c Release --no-build
@@ -151,10 +147,6 @@ jobs:
       DOTNET_SKIP_FIRST_TIME_EXPERIENCE: 1
       NUGET_XMLDOC_MODE: skip
     steps:
-      # setup dotnet for nuget push
-      - uses: actions/setup-dotnet@v1
-        with:
-          dotnet-version: "${{ env.DOTNET_SDK_VERSION_3 }}"
       # Create Releases
       - uses: actions/create-release@v1
         id: create_release

README.md

@@ -86,8 +86,8 @@ async UniTask<string> DemoAsync()
     await UniTask.Yield();
     await UniTask.NextFrame();
 
-    // replacement of WaitForEndOfFrame(same as UniTask.Yield(PlayerLoopTiming.LastPostLateUpdate))
+    // replacement of WaitForEndOfFrame(requires MonoBehaviour(CoroutineRunner))
-    await UniTask.WaitForEndOfFrame();
+    await UniTask.WaitForEndOfFrame(this); // this is MonoBehaviour
 
     // replacement of yield return new WaitForFixedUpdate(same as UniTask.Yield(PlayerLoopTiming.FixedUpdate))
     await UniTask.WaitForFixedUpdate();
@@ -496,17 +496,17 @@ public enum PlayerLoopTiming
 
 It indicates when to run, you can check [PlayerLoopList.md](https://gist.github.com/neuecc/bc3a1cfd4d74501ad057e49efcd7bdae) to Unity's default playerloop and injected UniTask's custom loop.
 
-`PlayerLoopTiming.Update` is similar to `yield return null` in a coroutine, but it is called before Update(Update and uGUI events(button.onClick, etc...) are called on `ScriptRunBehaviourUpdate`, yield return null is called on `ScriptRunDelayedDynamicFrameRate`). `PlayerLoopTiming.FixedUpdate` is similar to `WaitForFixedUpdate`, `PlayerLoopTiming.LastPostLateUpdate` is similar to `WaitForEndOfFrame` in coroutine.
+`PlayerLoopTiming.Update` is similar to `yield return null` in a coroutine, but it is called before Update(Update and uGUI events(button.onClick, etc...) are called on `ScriptRunBehaviourUpdate`, yield return null is called on `ScriptRunDelayedDynamicFrameRate`). `PlayerLoopTiming.FixedUpdate` is similar to `WaitForFixedUpdate`.
 
-> `await UniTask.WaitForEndOfFrame()` is not equivalent to coroutine's `yield return new WaitForEndOfFrame()`. Coroutine's WaitForEndOfFrame seems to run after the PlayerLoop is done. Some methods that require coroutine's end of frame(`ScreenCapture.CaptureScreenshotAsTexture`, `CommandBuffer`, etc) do not work correctly when replaced with async/await. In these cases, use a coroutine instead.
+> `PlayerLoopTiming.LastPostLateUpdate` is not equivalent to coroutine's `yield return new WaitForEndOfFrame()`. Coroutine's WaitForEndOfFrame seems to run after the PlayerLoop is done. Some methods that require coroutine's end of frame(`Texture2D.ReadPixels`, `ScreenCapture.CaptureScreenshotAsTexture`, `CommandBuffer`, etc) do not work correctly when replaced with async/await. In these cases, pass MonoBehaviour(coroutine runnner) to `UniTask.WaitForEndOfFrame`. For example, `await UniTask.WaitForEndOfFrame(this);` is lightweight allocation free alternative of `yield return new WaitForEndOfFrame()`.
 
 `yield return null` and `UniTask.Yield` are similar but different. `yield return null` always returns next frame but `UniTask.Yield` returns next called. That is, call `UniTask.Yield(PlayerLoopTiming.Update)` on `PreUpdate`, it returns same frame. `UniTask.NextFrame()` guarantees return next frame, you can expect this to behave exactly the same as `yield return null`.
 
-> UniTask.Yield(without CancellationToken) is a special type, returns `YieldAwaitable` and run on YieldRunner. It is most lightweight and fastest.
+> UniTask.Yield(without CancellationToken) is a special type, returns `YieldAwaitable` and runs on YieldRunner. It is the most lightweight and fastest.
 
 `AsyncOperation` is returned from native timing. For example, await `SceneManager.LoadSceneAsync` is returned from `EarlyUpdate.UpdatePreloading` and after being called, the loaded scene's `Start` is called from `EarlyUpdate.ScriptRunDelayedStartupFrame`. Also `await UnityWebRequest` is returned from `EarlyUpdate.ExecuteMainThreadJobs`.
 
-In UniTask, await directly uses native timing, `WithCancellation` and `ToUniTask` use specified timing. This is usually not a particular problem, but with `LoadSceneAsync`, it causes a different order of Start and continuation after await. So it is recommended not to use `LoadSceneAsync.ToUniTask`.
+In UniTask, await directly uses native timing, while `WithCancellation` and `ToUniTask` use specified timing. This is usually not a particular problem, but with `LoadSceneAsync`, it causes a different order of Start and continuation after await. So it is recommended not to use `LoadSceneAsync.ToUniTask`.
 
 In the stacktrace, you can check where it is running in playerloop.
 
@@ -805,32 +805,13 @@ async UniTask TripleClick(CancellationToken token)
 }
 ```
 
-All MonoBehaviour message events can convert async-streams by `AsyncTriggers` that can be enabled by `using Cysharp.Threading.Tasks.Triggers;`.
+All MonoBehaviour message events can convert async-streams by `AsyncTriggers` that can be enabled by `using Cysharp.Threading.Tasks.Triggers;`. AsyncTrigger can be created using `GetAsync***Trigger` and triggers itself as UniTaskAsyncEnumerable.
 
 ```csharp
-using Cysharp.Threading.Tasks.Triggers;
+var trigger = this.GetOnCollisionEnterAsyncHandler();
-
+await trigger.OnCollisionEnterAsync();
-async UniTaskVoid MonitorCollision()
+await trigger.OnCollisionEnterAsync();
-{
+await trigger.OnCollisionEnterAsync();
-    await gameObject.OnCollisionEnterAsync();
-    Debug.Log("Collision Enter");
-    /* do anything */
-
-    await gameObject.OnCollisionExitAsync();
-    Debug.Log("Collision Exit");
-}
-```
-
-Similar to uGUI event, AsyncTrigger can be created using `GetAsync***Trigger` and triggers itself as UniTaskAsyncEnumerable.
-
-```csharp
-// use await multiple times, get AsyncTriggerHandler is more efficient.
-using(var trigger = this.GetOnCollisionEnterAsyncHandler())
-{
-    await OnCollisionEnterAsync();
-    await OnCollisionEnterAsync();
-    await OnCollisionEnterAsync();
-}
 
 // every moves.
 await this.GetAsyncMoveTrigger().ForEachAsync(axisEventData =>
@@ -858,9 +839,9 @@ rp.WithoutCurrent().BindTo(this.textComponent);
 
 await rp.WaitAsync(); // wait until next value set
 
-// also exists ToReadOnlyReactiveProperty
+// also exists ToReadOnlyAsyncReactiveProperty
 var rp2 = new AsyncReactiveProperty<int>(99);
-var rorp = rp.CombineLatest(rp2, (x, y) => (x, y)).ToReadOnlyReactiveProperty();
+var rorp = rp.CombineLatest(rp2, (x, y) => (x, y)).ToReadOnlyAsyncReactiveProperty(CancellationToken.None);
 ```
 
 A pull-type asynchronous stream does not get the next values until the asynchronous processing in the sequence is complete. This could spill data from push-type events such as buttons.
@@ -966,9 +947,9 @@ UniTask's own unit tests are written using Unity Test Runner and [Cysharp/Runtim
 
 ThreadPool limitation
 ---
-Most UniTask methods run on a single thread (PlayerLoop), with only `UniTask.Run` and `UniTask.SwitchToThreadPool` running on a thread pool. If you use a thread pool, it won't work with WebGL and so on.
+Most UniTask methods run on a single thread (PlayerLoop), with only `UniTask.Run`(`Task.Run` equivalent) and `UniTask.SwitchToThreadPool` running on a thread pool. If you use a thread pool, it won't work with WebGL and so on.
 
-`UniTask.Run` will be deprecated in the future (marked with an Obsolete) and only `RunOnThreadPool` will be used. If you use `UniTask.Run`, consider whether you can use `UniTask.Create` or `UniTask.Void`.
+`UniTask.Run` is now deprecated. You can use `UniTask.RunOnThreadPool` instead. And also consider whether you can use `UniTask.Create` or `UniTask.Void`.
 
 IEnumerator.ToUniTask limitation
 ---
@@ -1023,7 +1004,7 @@ Use UniTask type.
 | `IAsyncDisposable` | `IUniTaskAsyncDisposable` |
 | `Task.Delay` | `UniTask.Delay` |
 | `Task.Yield` | `UniTask.Yield` |
-| `Task.Run` | `UniTask.Run` |
+| `Task.Run` | `UniTask.RunOnThreadPool` |
 | `Task.WhenAll` | `UniTask.WhenAll` |
 | `Task.WhenAny` | `UniTask.WhenAny` |
 | `Task.CompletedTask` | `UniTask.CompletedTask` |

UniTask.NetCore.sln

@@ -1,13 +1,15 @@
 
 Microsoft Visual Studio Solution File, Format Version 12.00
-# Visual Studio Version 16
+# Visual Studio Version 17
-VisualStudioVersion = 16.0.29613.14
+VisualStudioVersion = 17.0.31606.5
 MinimumVisualStudioVersion = 10.0.40219.1
-Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "UniTask.NetCoreTests", "src\UniTask.NetCoreTests\UniTask.NetCoreTests.csproj", "{B3E311A4-70D8-4131-9965-C073A99D201A}"
+Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "UniTask.NetCoreTests", "src\UniTask.NetCoreTests\UniTask.NetCoreTests.csproj", "{B3E311A4-70D8-4131-9965-C073A99D201A}"
 EndProject
 Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "UniTask.NetCore", "src\UniTask.NetCore\UniTask.NetCore.csproj", "{16EE20D0-7FB1-483A-8467-A5EEDBF1F5BF}"
 EndProject
-Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "UniTask.NetCoreSandbox", "src\UniTask.NetCoreSandbox\UniTask.NetCoreSandbox.csproj", "{3915E72E-33E0-4A14-A6D8-872702200E58}"
+Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "UniTask.NetCoreSandbox", "src\UniTask.NetCoreSandbox\UniTask.NetCoreSandbox.csproj", "{3915E72E-33E0-4A14-A6D8-872702200E58}"
+EndProject
+Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "UniTask.Analyzer", "src\UniTask.Analyzer\UniTask.Analyzer.csproj", "{0AC6F052-A255-4EE3-9E05-1C02D49AB1C2}"
 EndProject
 Global
 	GlobalSection(SolutionConfigurationPlatforms) = preSolution
@@ -27,6 +29,10 @@ Global
 		{3915E72E-33E0-4A14-A6D8-872702200E58}.Debug|Any CPU.Build.0 = Debug|Any CPU
 		{3915E72E-33E0-4A14-A6D8-872702200E58}.Release|Any CPU.ActiveCfg = Release|Any CPU
 		{3915E72E-33E0-4A14-A6D8-872702200E58}.Release|Any CPU.Build.0 = Release|Any CPU
+		{0AC6F052-A255-4EE3-9E05-1C02D49AB1C2}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
+		{0AC6F052-A255-4EE3-9E05-1C02D49AB1C2}.Debug|Any CPU.Build.0 = Debug|Any CPU
+		{0AC6F052-A255-4EE3-9E05-1C02D49AB1C2}.Release|Any CPU.ActiveCfg = Release|Any CPU
+		{0AC6F052-A255-4EE3-9E05-1C02D49AB1C2}.Release|Any CPU.Build.0 = Release|Any CPU
 	EndGlobalSection
 	GlobalSection(SolutionProperties) = preSolution
 		HideSolutionNode = FALSE

src/UniTask.Analyzer/Properties/launchSettings.json

@@ -0,0 +1,8 @@
+{
+  "profiles": {
+    "UniTask.Analyzer": {
+      "commandName": "DebugRoslynComponent",
+      "targetProject": "..\\UniTask.NetCoreSandbox\\UniTask.NetCoreSandbox.csproj"
+    }
+  }
+}

src/UniTask.Analyzer/UniTask.Analyzer.csproj

@@ -0,0 +1,29 @@
+<Project Sdk="Microsoft.NET.Sdk">
+    <PropertyGroup>
+        <OutputType>library</OutputType>
+        <TargetFramework>netstandard2.0</TargetFramework>
+        <LangVersion>latest</LangVersion>
+        <Nullable>enable</Nullable>
+        <IsRoslynComponent>true</IsRoslynComponent>
+        <TargetsForTfmSpecificContentInPackage>$(TargetsForTfmSpecificContentInPackage);PackBuildOutputs</TargetsForTfmSpecificContentInPackage>
+        <IncludeBuildOutput>false</IncludeBuildOutput>
+        <IncludeSymbols>false</IncludeSymbols>
+        <SuppressDependenciesWhenPacking>true</SuppressDependenciesWhenPacking>
+        <DevelopmentDependency>true</DevelopmentDependency>
+    </PropertyGroup>
+
+    <ItemGroup>
+        <PackageReference Include="Microsoft.CodeAnalysis.Analyzers" Version="3.3.2">
+            <IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>
+            <PrivateAssets>all</PrivateAssets>
+        </PackageReference>
+        <PackageReference Include="Microsoft.CodeAnalysis.CSharp" Version="3.8.0" />
+    </ItemGroup>
+
+    <Target Name="PackBuildOutputs" DependsOnTargets="SatelliteDllsProjectOutputGroup;DebugSymbolsProjectOutputGroup">
+        <ItemGroup>
+            <TfmSpecificPackageFile Include="$(TargetDir)\*.dll" PackagePath="analyzers\dotnet\cs" />
+            <TfmSpecificPackageFile Include="@(SatelliteDllsProjectOutputGroupOutput->'%(FinalOutputPath)')" PackagePath="analyzers\dotnet\cs\%(SatelliteDllsProjectOutputGroupOutput.Culture)\" />
+        </ItemGroup>
+    </Target>
+</Project>

src/UniTask.Analyzer/UniTaskAnalyzer.cs

@@ -0,0 +1,54 @@
+#pragma warning disable RS2008
+
+using Microsoft.CodeAnalysis;
+using Microsoft.CodeAnalysis.Diagnostics;
+using Microsoft.CodeAnalysis.Operations;
+using System.Collections.Immutable;
+using System.Threading;
+
+namespace UniTask.Analyzer
+{
+    [DiagnosticAnalyzer(LanguageNames.CSharp)]
+    public class UniTaskAnalyzer : DiagnosticAnalyzer
+    {
+        private static readonly DiagnosticDescriptor Rule = new DiagnosticDescriptor(
+            id: "UNITASK001",
+            title: "UniTaskAnalyzer001: Must pass CancellationToken",
+            messageFormat: "Must pass CancellationToken",
+            category: "Usage",
+            defaultSeverity: DiagnosticSeverity.Error,
+            isEnabledByDefault: true,
+            description: "Pass CancellationToken or CancellationToken.None.");
+
+        public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics { get { return ImmutableArray.Create(Rule); } }
+
+        public override void Initialize(AnalysisContext context)
+        {
+            context.ConfigureGeneratedCodeAnalysis(GeneratedCodeAnalysisFlags.None);
+            context.EnableConcurrentExecution();
+
+            context.RegisterOperationAction(AnalyzeOperation, OperationKind.Invocation);
+        }
+
+        private static void AnalyzeOperation(OperationAnalysisContext context)
+        {
+            var token = context.Compilation.GetTypeByMetadataName(typeof(CancellationToken).FullName);
+            if (token == null) return;
+
+            if (context.Operation is IInvocationOperation invocation)
+            {
+                foreach (var arg in invocation.Arguments)
+                {
+                    if (arg.ArgumentKind == ArgumentKind.DefaultValue)
+                    {
+                        if (SymbolEqualityComparer.Default.Equals(arg.Parameter.Type, token))
+                        {
+                            var diagnostic = Diagnostic.Create(Rule, arg.Syntax.GetLocation());
+                            context.ReportDiagnostic(diagnostic);
+                        }
+                    }
+                }
+            }
+        }
+    }
+}

src/UniTask.NetCore/UniTask.NetCore.csproj

@@ -5,6 +5,8 @@
         <AssemblyName>UniTask</AssemblyName>
         <LangVersion>8.0</LangVersion>
         <RootNamespace>Cysharp.Threading.Tasks</RootNamespace>
+        <GenerateDocumentationFile>true</GenerateDocumentationFile>
+        <NoWarn>$(NoWarn);CS1591</NoWarn>
 
         <!-- NuGet Packaging -->
         <Id>UniTask</Id>

src/UniTask.NetCoreSandbox/AllocationCheck.cs

@@ -1,258 +0,0 @@
-using BenchmarkDotNet.Attributes;
-using System.Linq;
-using BenchmarkDotNet.Configs;
-using BenchmarkDotNet.Diagnosers;
-using BenchmarkDotNet.Exporters;
-using BenchmarkDotNet.Jobs;
-using BenchmarkDotNet.Running;
-using Cysharp.Threading.Tasks;
-using PooledAwait;
-using System;
-using System.Runtime.ExceptionServices;
-using System.Threading.Tasks;
-using System.Threading;
-using System.Runtime.CompilerServices;
-using Cysharp.Threading.Tasks.CompilerServices;
-using System.Collections.Concurrent;
-
-[Config(typeof(BenchmarkConfig))]
-public class AllocationCheck
-{
-    // note: all the benchmarks use Task/Task<T> for the public API, because BenchmarkDotNet
-    // doesn't work reliably with more exotic task-types (even just ValueTask fails); instead,
-    // we'll obscure the cost of the outer awaitable by doing a relatively large number of
-    // iterations, so that we're only really measuring the inner loop
-    private const int InnerOps = 1000;
-
-    [Benchmark(OperationsPerInvoke = InnerOps)]
-    public async Task ViaUniTask()
-    {
-        for (int i = 0; i < InnerOps; i++)
-        {
-            var a = Core();
-            var b = Core();
-            var c = Core();
-            await a;
-            await b;
-            await c;
-        }
-
-        static async UniTask Core()
-        {
-            await new TestAwaiter(false, UniTaskStatus.Succeeded);
-            await new TestAwaiter(false, UniTaskStatus.Succeeded);
-            await new TestAwaiter(false, UniTaskStatus.Succeeded);
-        }
-    }
-
-    [Benchmark(OperationsPerInvoke = InnerOps)]
-    public async Task<int> ViaUniTaskT()
-    {
-        var sum = 0;
-        for (int i = 0; i < InnerOps; i++)
-        {
-            var a = Core();
-            var b = Core();
-            var c = Core();
-            sum += await a;
-            sum += await b;
-            sum += await c;
-        }
-        return sum;
-
-        static async UniTask<int> Core()
-        {
-            var a = await new TestAwaiter<int>(false, UniTaskStatus.Succeeded, 10);
-            var b = await new TestAwaiter<int>(false, UniTaskStatus.Succeeded, 10);
-            var c = await new TestAwaiter<int>(false, UniTaskStatus.Succeeded, 10);
-            return 10;
-        }
-    }
-
-    //[Benchmark(OperationsPerInvoke = InnerOps)]
-    //[Benchmark]
-    public void ViaUniTaskVoid()
-    {
-        for (int i = 0; i < InnerOps; i++)
-        {
-            Core().Forget();
-            Core().Forget();
-            Core().Forget();
-        }
-
-        static async UniTaskVoid Core()
-        {
-            await new TestAwaiter(false, UniTaskStatus.Succeeded);
-            await new TestAwaiter(false, UniTaskStatus.Succeeded);
-            await new TestAwaiter(false, UniTaskStatus.Succeeded);
-        }
-    }
-
-    struct Foo : IAsyncStateMachine
-    {
-        public AsyncUniTaskVoidMethodBuilder builder;
-        public TestAwaiter awaiter;
-        public TestAwaiter awaiterawaiter;
-
-        public int state;
-
-        public void MoveNext()
-        {
-            switch (state)
-            {
-                case -1:
-                    awaiterawaiter = awaiter.GetAwaiter();
-                    if (awaiterawaiter.IsCompleted)
-                    {
-                        goto case 0;
-                    }
-                    else
-                    {
-                        state = 0;
-                        builder.AwaitUnsafeOnCompleted(ref awaiterawaiter, ref this);
-                        return;
-                    }
-
-                case 0:
-                default:
-                    goto END;
-            }
-
-            END:
-            builder.SetResult();
-        }
-
-        public void SetStateMachine(IAsyncStateMachine stateMachine)
-        {
-
-        }
-    }
-}
-
-public class TaskTestException : Exception
-{
-
-}
-
-public struct TestAwaiter : ICriticalNotifyCompletion
-{
-    readonly UniTaskStatus status;
-    readonly bool isCompleted;
-
-    public TestAwaiter(bool isCompleted, UniTaskStatus status)
-    {
-        this.isCompleted = isCompleted;
-        this.status = status;
-    }
-
-    public TestAwaiter GetAwaiter() => this;
-
-    public bool IsCompleted => isCompleted;
-
-    public void GetResult()
-    {
-        switch (status)
-        {
-            case UniTaskStatus.Faulted:
-                throw new TaskTestException();
-            case UniTaskStatus.Canceled:
-                throw new OperationCanceledException();
-            case UniTaskStatus.Pending:
-            case UniTaskStatus.Succeeded:
-            default:
-                break;
-        }
-    }
-
-    public void OnCompleted(Action continuation)
-    {
-        ThreadPool.UnsafeQueueUserWorkItem(ThreadPoolWorkItem.Create(continuation), false);
-    }
-
-    public void UnsafeOnCompleted(Action continuation)
-    {
-        ThreadPool.UnsafeQueueUserWorkItem(ThreadPoolWorkItem.Create(continuation), false);
-    }
-
-
-}
-
-public struct TestAwaiter<T> : ICriticalNotifyCompletion
-{
-    readonly UniTaskStatus status;
-    readonly bool isCompleted;
-    readonly T value;
-
-    public TestAwaiter(bool isCompleted, UniTaskStatus status, T value)
-    {
-        this.isCompleted = isCompleted;
-        this.status = status;
-        this.value = value;
-    }
-
-    public TestAwaiter<T> GetAwaiter() => this;
-
-    public bool IsCompleted => isCompleted;
-
-    public T GetResult()
-    {
-        switch (status)
-        {
-            case UniTaskStatus.Faulted:
-                throw new TaskTestException();
-            case UniTaskStatus.Canceled:
-                throw new OperationCanceledException();
-            case UniTaskStatus.Pending:
-            case UniTaskStatus.Succeeded:
-            default:
-                return value;
-        }
-    }
-
-    public void OnCompleted(Action continuation)
-    {
-        ThreadPool.UnsafeQueueUserWorkItem(ThreadPoolWorkItem.Create(continuation), false);
-    }
-
-    public void UnsafeOnCompleted(Action continuation)
-    {
-        ThreadPool.UnsafeQueueUserWorkItem(ThreadPoolWorkItem.Create(continuation), false);
-    }
-}
-
-public sealed class ThreadPoolWorkItem : IThreadPoolWorkItem
-{
-    public static readonly ConcurrentQueue<ThreadPoolWorkItem> pool = new ConcurrentQueue<ThreadPoolWorkItem>();
-
-    public static void CreatePoolItems(int count)
-    {
-        for (int i = 0; i < count; i++)
-        {
-            pool.Enqueue(new ThreadPoolWorkItem());
-        }
-    }
-
-    Action continuation;
-
-    [MethodImpl(MethodImplOptions.AggressiveInlining)]
-    public static ThreadPoolWorkItem Create(Action continuation)
-    {
-        if (!pool.TryDequeue(out var item))
-        {
-            item = new ThreadPoolWorkItem();
-        }
-
-        item.continuation = continuation;
-        return item;
-    }
-
-    [MethodImpl(MethodImplOptions.AggressiveInlining)]
-    public void Execute()
-    {
-        var call = continuation;
-        continuation = null;
-        pool.Enqueue(this);
-
-        call.Invoke();
-    }
-}

src/UniTask.NetCoreSandbox/Benchmark.cs

@@ -1,283 +0,0 @@
-using BenchmarkDotNet.Attributes;
-using System.Linq;
-using BenchmarkDotNet.Configs;
-using BenchmarkDotNet.Diagnosers;
-using BenchmarkDotNet.Exporters;
-using BenchmarkDotNet.Jobs;
-using BenchmarkDotNet.Running;
-using Cysharp.Threading.Tasks;
-using PooledAwait;
-using System;
-using System.Runtime.ExceptionServices;
-using System.Threading.Tasks;
-using System.Threading;
-using System.Runtime.CompilerServices;
-using Cysharp.Threading.Tasks.CompilerServices;
-
-//class Program
-//{
-//    static void Main(string[] args)
-//    {
-//        var switcher = new BenchmarkSwitcher(new[]
-//        {
-//            typeof(StandardBenchmark)
-//        });
-
-//#if DEBUG
-//        var b = new StandardBenchmark();
-
-//#else
-//        switcher.Run(args);
-//#endif
-//    }
-//}
-
-public class BenchmarkConfig : ManualConfig
-{
-    public BenchmarkConfig()
-    {
-        AddDiagnoser(MemoryDiagnoser.Default);
-        AddJob(Job.ShortRun.WithLaunchCount(1).WithIterationCount(1).WithWarmupCount(1)/*.RunOncePerIteration()*/);
-    }
-}
-
-// borrowed from PooledAwait
-
-[Config(typeof(BenchmarkConfig))]
-[GroupBenchmarksBy(BenchmarkLogicalGroupRule.ByCategory)]
-[CategoriesColumn]
-public class ComparisonBenchmarks
-{
-    // note: all the benchmarks use Task/Task<T> for the public API, because BenchmarkDotNet
-    // doesn't work reliably with more exotic task-types (even just ValueTask fails); instead,
-    // we'll obscure the cost of the outer awaitable by doing a relatively large number of
-    // iterations, so that we're only really measuring the inner loop
-    private const int InnerOps = 1000;
-
-    public bool ConfigureAwait { get; set; } = false;
-
-    [Benchmark(OperationsPerInvoke = InnerOps, Description = ".NET")]
-    [BenchmarkCategory("Task<T>")]
-    public async Task<int> ViaTaskT()
-    {
-        int sum = 0;
-        for (int i = 0; i < InnerOps; i++)
-            sum += await Inner(1, 2).ConfigureAwait(ConfigureAwait);
-        return sum;
-
-        static async Task<int> Inner(int x, int y)
-        {
-            int i = x;
-            await Task.Yield();
-            i *= y;
-            await Task.Yield();
-            return 5 * i;
-        }
-    }
-
-    [Benchmark(OperationsPerInvoke = InnerOps, Description = ".NET")]
-    [BenchmarkCategory("Task")]
-    public async Task ViaTask()
-    {
-        for (int i = 0; i < InnerOps; i++)
-            await Inner().ConfigureAwait(ConfigureAwait);
-
-        static async Task Inner()
-        {
-            await Task.Yield();
-            await Task.Yield();
-        }
-    }
-
-    [Benchmark(OperationsPerInvoke = InnerOps, Description = ".NET")]
-    [BenchmarkCategory("ValueTask<T>")]
-    public async Task<int> ViaValueTaskT()
-    {
-        int sum = 0;
-        for (int i = 0; i < InnerOps; i++)
-            sum += await Inner(1, 2).ConfigureAwait(ConfigureAwait);
-        return sum;
-
-        static async ValueTask<int> Inner(int x, int y)
-        {
-            int i = x;
-            await Task.Yield();
-            i *= y;
-            await Task.Yield();
-            return 5 * i;
-        }
-    }
-
-    [Benchmark(OperationsPerInvoke = InnerOps, Description = ".NET")]
-    [BenchmarkCategory("ValueTask")]
-    public async Task ViaValueTask()
-    {
-        for (int i = 0; i < InnerOps; i++)
-            await Inner().ConfigureAwait(ConfigureAwait);
-
-        static async ValueTask Inner()
-        {
-            await Task.Yield();
-            await Task.Yield();
-        }
-    }
-
-    [Benchmark(OperationsPerInvoke = InnerOps, Description = "Pooled")]
-    [BenchmarkCategory("ValueTask<T>")]
-    public async Task<int> ViaPooledValueTaskT()
-    {
-        int sum = 0;
-        for (int i = 0; i < InnerOps; i++)
-            sum += await Inner(1, 2).ConfigureAwait(ConfigureAwait);
-        return sum;
-
-        static async PooledValueTask<int> Inner(int x, int y)
-        {
-            int i = x;
-            await Task.Yield();
-            i *= y;
-            await Task.Yield();
-            return 5 * i;
-        }
-    }
-
-    [Benchmark(OperationsPerInvoke = InnerOps, Description = "Pooled")]
-    [BenchmarkCategory("ValueTask")]
-    public async Task ViaPooledValueTask()
-    {
-        for (int i = 0; i < InnerOps; i++)
-            await Inner().ConfigureAwait(ConfigureAwait);
-
-        static async PooledValueTask Inner()
-        {
-            await Task.Yield();
-            await Task.Yield();
-        }
-    }
-
-    [Benchmark(OperationsPerInvoke = InnerOps, Description = "Pooled")]
-    [BenchmarkCategory("Task<T>")]
-    public async Task<int> ViaPooledTaskT()
-    {
-        int sum = 0;
-        for (int i = 0; i < InnerOps; i++)
-            sum += await Inner(1, 2).ConfigureAwait(ConfigureAwait);
-        return sum;
-
-        static async PooledTask<int> Inner(int x, int y)
-        {
-            int i = x;
-            await Task.Yield();
-            i *= y;
-            await Task.Yield();
-            return 5 * i;
-        }
-    }
-
-    [Benchmark(OperationsPerInvoke = InnerOps, Description = "Pooled")]
-    [BenchmarkCategory("Task")]
-    public async Task ViaPooledTask()
-    {
-        for (int i = 0; i < InnerOps; i++)
-            await Inner().ConfigureAwait(ConfigureAwait);
-
-        static async PooledTask Inner()
-        {
-            await Task.Yield();
-            await Task.Yield();
-        }
-    }
-
-    // ---
-
-    //[Benchmark(OperationsPerInvoke = InnerOps, Description = "UniTaskVoid")]
-    //[BenchmarkCategory("UniTask")]
-    //public async Task ViaUniTaskVoid()
-    //{
-    //    for (int i = 0; i < InnerOps; i++)
-    //    {
-    //        await Inner();
-    //    }
-
-    //    static async UniTaskVoid Inner()
-    //    {
-    //        await UniTask.Yield();
-    //        await UniTask.Yield();
-    //    }
-    //}
-
-    [Benchmark(OperationsPerInvoke = InnerOps, Description = "UniTask")]
-    [BenchmarkCategory("UniTask")]
-    public async Task ViaUniTask()
-    {
-        for (int i = 0; i < InnerOps; i++)
-        {
-            await Inner();
-        }
-
-        static async UniTask Inner()
-        {
-            await UniTask.Yield();
-            await UniTask.Yield();
-        }
-    }
-
-    [Benchmark(OperationsPerInvoke = InnerOps, Description = "UniTaskT")]
-    [BenchmarkCategory("UniTask")]
-    public async Task<int> ViaUniTaskT()
-    {
-        var sum = 0;
-        for (int i = 0; i < InnerOps; i++)
-        {
-            sum += await Inner(1, 2);
-        }
-        return sum;
-
-        static async UniTask<int> Inner(int x, int y)
-        {
-            int i = x;
-            await UniTask.Yield();
-            i *= y;
-            await UniTask.Yield();
-            return 5 * i;
-        }
-    }
-}
-
-public struct MyAwaiter : ICriticalNotifyCompletion
-{
-    public MyAwaiter GetAwaiter() => this;
-
-    public bool IsCompleted => false;
-
-    public void GetResult()
-    {
-    }
-
-    public void OnCompleted(Action continuation)
-    {
-        continuation();
-    }
-
-    public void UnsafeOnCompleted(Action continuation)
-    {
-        continuation();
-    }
-}
-
-public struct MyTestStateMachine : IAsyncStateMachine
-{
-    public void MoveNext()
-    {
-        //throw new NotImplementedException();
-
-
-
-
-    }
-
-    public void SetStateMachine(IAsyncStateMachine stateMachine)
-    {
-        //throw new NotImplementedException();
-    }
-}

src/UniTask.NetCoreSandbox/Program.cs

@@ -17,499 +17,34 @@ using System.Reactive.Concurrency;
 
 namespace NetCoreSandbox
 {
-    public class MySyncContext : SynchronizationContext
+    public class Program
     {
-        public MySyncContext()
-        {
-        }
-
-        public override void Post(SendOrPostCallback d, object state)
-        {
-            Console.WriteLine("Called SyncContext Post!");
-            base.Post(d, state);
-        }
-    }
-
-    public class Text
-    {
-
-        public string text { get; set; }
-    }
-
-    public class ZeroAllocAsyncAwaitInDotNetCore
-    {
-        public ValueTask<int> NanikaAsync(int x, int y)
-        {
-            return Core(this, x, y);
-
-            static async UniTask<int> Core(ZeroAllocAsyncAwaitInDotNetCore self, int x, int y)
-            {
-                // nanika suru...
-                await Task.Delay(TimeSpan.FromSeconds(x + y));
-
-                return 10;
-            }
-        }
-    }
-
-
-    public class TaskTestException : Exception
-    {
-
-    }
-
-    class Foo
-    {
-        public async UniTask MethodFooAsync()
-        {
-            await MethodBarAsync();
-        }
-
-        private async UniTask MethodBarAsync()
-
-        {
-            Throw();
-        }
-
-        private void Throw()
-        {
-            throw new Exception();
-        }
-    }
-
-    public struct TestAwaiter : ICriticalNotifyCompletion
-    {
-        readonly UniTaskStatus status;
-        readonly bool isCompleted;
-
-        public TestAwaiter(bool isCompleted, UniTaskStatus status)
-        {
-            this.isCompleted = isCompleted;
-            this.status = status;
-        }
-
-        public TestAwaiter GetAwaiter() => this;
-
-        public bool IsCompleted => isCompleted;
-
-        public void GetResult()
-        {
-            switch (status)
-            {
-                case UniTaskStatus.Faulted:
-                    throw new TaskTestException();
-                case UniTaskStatus.Canceled:
-                    throw new OperationCanceledException();
-                case UniTaskStatus.Pending:
-                case UniTaskStatus.Succeeded:
-                default:
-                    break;
-            }
-        }
-
-        public void OnCompleted(Action continuation)
-        {
-            ThreadPool.QueueUserWorkItem(_ => continuation(), null);
-        }
-
-        public void UnsafeOnCompleted(Action continuation)
-        {
-            ThreadPool.UnsafeQueueUserWorkItem(_ => continuation(), null);
-        }
-    }
-    public struct TestAwaiter<T> : ICriticalNotifyCompletion
-    {
-        readonly UniTaskStatus status;
-        readonly bool isCompleted;
-        readonly T value;
-
-        public TestAwaiter(bool isCompleted, UniTaskStatus status, T value)
-        {
-            this.isCompleted = isCompleted;
-            this.status = status;
-            this.value = value;
-        }
-
-        public TestAwaiter<T> GetAwaiter() => this;
-
-        public bool IsCompleted => isCompleted;
-
-        public T GetResult()
-        {
-            switch (status)
-            {
-                case UniTaskStatus.Faulted:
-                    throw new TaskTestException();
-                case UniTaskStatus.Canceled:
-                    throw new OperationCanceledException();
-                case UniTaskStatus.Pending:
-                case UniTaskStatus.Succeeded:
-                default:
-                    return value;
-            }
-        }
-
-        public void OnCompleted(Action continuation)
-        {
-            ThreadPool.QueueUserWorkItem(_ => continuation(), null);
-        }
-
-        public void UnsafeOnCompleted(Action continuation)
-        {
-            ThreadPool.UnsafeQueueUserWorkItem(_ => continuation(), null);
-        }
-    }
-
-
-    public static partial class UnityUIComponentExtensions
-    {
-        public static void BindTo(this IUniTaskAsyncEnumerable<string> source, Text text)
-        {
-            AAAACORECORE(source, text).Forget();
-
-            async UniTaskVoid AAAACORECORE(IUniTaskAsyncEnumerable<string> source2, Text text2)
-            {
-                var e = source2.GetAsyncEnumerator();
-                try
-                {
-                    while (await e.MoveNextAsync())
-                    {
-                        text2.text = e.Current;
-                        // action(e.Current);
-                    }
-                }
-                finally
-                {
-                    if (e != null)
-                    {
-                        await e.DisposeAsync();
-                    }
-                }
-            }
-        }
-
-        //public static IDisposable SubscribeToText<T>(this IObservable<T> source, Text text)
-        //{
-        //    return source.SubscribeWithState(text, (x, t) => t.text = x.ToString());
-        //}
-
-        //public static IDisposable SubscribeToText<T>(this IObservable<T> source, Text text, Func<T, string> selector)
-        //{
-        //    return source.SubscribeWithState2(text, selector, (x, t, s) => t.text = s(x));
-        //}
-
-        //public static IDisposable SubscribeToInteractable(this IObservable<bool> source, Selectable selectable)
-        //{
-        //    return source.SubscribeWithState(selectable, (x, s) => s.interactable = x);
-        //}
-    }
-
-    class Program
-    {
-        static string FlattenGenArgs(Type type)
-        {
-            if (type.IsGenericType)
-            {
-                var t = string.Join(", ", type.GetGenericArguments().Select(x => FlattenGenArgs(x)));
-                return Regex.Replace(type.Name, "`.+", "") + "<" + t + ">";
-            }
-            //x.ReturnType.GetGenericArguments()
-            else
-            {
-                return type.Name;
-            }
-        }
-
-        static async IAsyncEnumerable<int> FooAsync([EnumeratorCancellation]CancellationToken cancellationToken = default)
-        {
-            yield return 1;
-            await Task.Delay(10, cancellationToken);
-        }
-
-        public class MyDisposable : IDisposable
-        {
-            public void Dispose()
-            {
-
-            }
-        }
-
-        static void Test()
-        {
-            var disp = new MyDisposable();
-
-            using var _ = new MyDisposable();
-
-            Console.WriteLine("tako");
-        }
-
-
-        static async UniTask FooBarAsync()
-        {
-            await using (UniTask.ReturnToCurrentSynchronizationContext())
-            {
-                await UniTask.SwitchToThreadPool();
-
-
-
-
-            }
-        }
-
-
-
-
-        static async UniTask Aaa()
-        {
-            await FooBarAsync();
-
-            Console.WriteLine("FooBarAsync End");
-        }
-
-        static async UniTask WhereSelect()
-        {
-            await foreach (var item in UniTaskAsyncEnumerable.Range(1, 10)
-                .SelectAwait(async x =>
-                {
-                    await UniTask.Yield();
-                    return x;
-                })
-                .Where(x => x % 2 == 0))
-            {
-                Console.WriteLine(item);
-            }
-        }
-
-
         static async Task Main(string[] args)
         {
-#if !DEBUG
+            var cts = new CancellationTokenSource();
-         
+
+
+            // OK.
+            await FooAsync(10, cts.Token);
+
+            // NG(Compiler Error)
+            // await FooAsync(10);
+
+
+
             
 
 
-            //await new AllocationCheck().ViaUniTaskVoid();
-            //Console.ReadLine();
-            BenchmarkDotNet.Running.BenchmarkSwitcher.FromAssembly(typeof(Program).Assembly).Run(args);
 
-            //await new ComparisonBenchmarks().ViaUniTaskT();
-            return;
-#endif
-
-            var e = UniTaskAsyncEnumerable.Create<int>(async (writer, token) =>
-            {
-                for (int i = 0; i < 5; i++)
-                {
-                    Console.WriteLine($"Start {i}");
-                    await writer.YieldAsync(i);
-                    Console.WriteLine($"End {i}");
-                }
-            });
-
-            var ee = e.GetAsyncEnumerator();
-            while (await ee.MoveNextAsync())
-            {
-                Console.WriteLine("ForEach " + ee.Current);
-            }
 
 
 
         }
 
-        static async UniTask YieldCore()
+        static async UniTask FooAsync(int x, CancellationToken cancellationToken = default)
         {
             await UniTask.Yield();
         }
-
-#pragma warning disable CS1998
-
-
-        static async UniTask<int> AsyncTest()
-        {
-            // empty 
-            await new TestAwaiter(false, UniTaskStatus.Succeeded);
-            await new TestAwaiter(true, UniTaskStatus.Succeeded);
-            await new TestAwaiter(false, UniTaskStatus.Succeeded);
-            return 10;
-        }
-
-
-
-#pragma warning restore CS1998
-
-        void Foo()
-        {
-
-            // AsyncEnumerable.Range(1,10).Do(
-
-            // AsyncEnumerable.t
-
-            var sb = new StringBuilder();
-            sb.AppendLine(@"using System;
-using System.Threading;
-
-namespace Cysharp.Threading.Tasks.Linq
-{
-");
-
-
-
-            var chako = typeof(AsyncEnumerable).GetMethods()
-                .OrderBy(x => x.Name)
-                .Select(x =>
-                {
-                    var ret = FlattenGenArgs(x.ReturnType);
-
-
-                    var generics = string.Join(", ", x.GetGenericArguments().Select(x => x.Name));
-
-                    if (x.GetParameters().Length == 0) return "";
-
-                    var self = x.GetParameters().First();
-                    if (x.GetCustomAttributes(typeof(ExtensionAttribute), true).Length == 0)
-                    {
-                        return "";
-                    }
-
-                    var arg1Type = FlattenGenArgs(x.GetParameters().First().ParameterType);
-
-                    var others = string.Join(", ", x.GetParameters().Skip(1).Select(y => FlattenGenArgs(y.ParameterType) + " " + y.Name));
-
-                    if (!string.IsNullOrEmpty(others))
-                    {
-                        others = ", " + others;
-                    }
-
-                    var template = $"public static {ret} {x.Name}<{generics}>(this {arg1Type} {self.Name}{others})";
-
-
-
-                    return template.Replace("ValueTask", "UniTask").Replace("IAsyncEnumerable", "IUniTaskAsyncEnumerable").Replace("<>", "");
-                })
-                .Where(x => x != "")
-                .Select(x => x + "\r\n{\r\n    throw new NotImplementedException();\r\n}")
-                .ToArray();
-
-            var huga = string.Join("\r\n\r\n", chako);
-
-
-
-
-            foreach (var item in typeof(AsyncEnumerable).GetMethods().Select(x => x.Name).Distinct())
-            {
-                if (item.EndsWith("AwaitAsync") || item.EndsWith("AwaitWithCancellationAsync") || item.EndsWith("WithCancellation"))
-                {
-                    continue;
-                }
-
-                var item2 = item.Replace("Async", "");
-                item2 = item2.Replace("Await", "");
-
-                var format = @"
-    internal sealed class {0}
-    {{
-    }}
-";
-
-                sb.Append(string.Format(format, item2));
-
-            }
-
-            sb.Append("}");
-
-
-            Console.WriteLine(sb.ToString());
-
-
-
-
-        }
-
-
-        public static async IAsyncEnumerable<int> AsyncGen()
-        {
-            await UniTask.SwitchToThreadPool();
-            yield return 10;
-            await UniTask.SwitchToThreadPool();
-            yield return 100;
-        }
     }
 
-    class MyEnumerable : IEnumerable<int>
-    {
-        public IEnumerator<int> GetEnumerator()
-        {
-            return new MyEnumerator();
-        }
-
-        IEnumerator IEnumerable.GetEnumerator()
-        {
-            throw new NotImplementedException();
-        }
-    }
-
-    class MyEnumerator : IEnumerator<int>
-    {
-        public int Current => throw new NotImplementedException();
-
-        object IEnumerator.Current => throw new NotImplementedException();
-
-        public void Dispose()
-        {
-            Console.WriteLine("Called Dispose");
-        }
-
-        public bool MoveNext()
-        {
-            throw new NotImplementedException();
-        }
-
-        public void Reset()
-        {
-            throw new NotImplementedException();
-        }
-    }
-
-
-
-    public class MyClass<T>
-    {
-        public CustomAsyncEnumerator<T> GetAsyncEnumerator()
-        {
-            //IAsyncEnumerable
-            return new CustomAsyncEnumerator<T>();
-        }
-    }
-
-
-    public struct CustomAsyncEnumerator<T>
-    {
-        int count;
-
-        public T Current
-        {
-            get
-            {
-                return default;
-            }
-        }
-
-        public UniTask<bool> MoveNextAsync()
-        {
-            if (count++ == 3)
-            {
-                return UniTask.FromResult(false);
-                //return false;
-            }
-            return UniTask.FromResult(true);
-        }
-
-        public UniTask DisposeAsync()
-        {
-            return default;
-        }
-    }
-
-
-
 }

src/UniTask.NetCoreSandbox/QueueCheck.cs

@@ -1,473 +0,0 @@
-using BenchmarkDotNet.Attributes;
-using System.Collections.Concurrent;
-using System.Collections.Generic;
-using System.Runtime.CompilerServices;
-using System.Runtime.InteropServices;
-using System.Threading;
-
-[Config(typeof(BenchmarkConfig))]
-public class QueueCheck
-{
-    Node node1 = new Node();
-    Node node2 = new Node();
-    RefNode refNode1 = new RefNode();
-    RefNode refNode2 = new RefNode();
-    Queue<Node> q1 = new Queue<Node>();
-    Stack<Node> s1 = new Stack<Node>();
-    ConcurrentQueue<Node> cq = new ConcurrentQueue<Node>();
-    ConcurrentStack<Node> cs = new ConcurrentStack<Node>();
-    static TaskPool<Node> pool;
-    static TaskPoolRefNode<RefNode> poolRefNode;
-    static TaskPoolEqualNull<Node> poolEqualNull;
-    static TaskPoolClass<Node> poolClass = new TaskPoolClass<Node>();
-    static TaskPoolWithoutSize<Node> poolWithoutSize;
-    static TaskPoolWithoutLock<Node> poolWithoutLock;
-
-    [Benchmark]
-    public void Queue()
-    {
-        q1.Enqueue(node1);
-        q1.Enqueue(node1);
-        q1.TryDequeue(out _);
-        q1.TryDequeue(out _);
-    }
-
-    [Benchmark]
-    public void QueueLock()
-    {
-        lock (q1) { q1.Enqueue(node1); }
-        lock (q1) { q1.Enqueue(node1); }
-        lock (q1) { q1.TryDequeue(out _); }
-        lock (q1) { q1.TryDequeue(out _); }
-    }
-
-    [Benchmark]
-    public void Stack()
-    {
-        s1.Push(node1);
-        s1.Push(node2);
-        s1.TryPop(out _);
-        s1.TryPop(out _);
-    }
-
-    [Benchmark]
-    public void StackLock()
-    {
-        lock (s1) { s1.Push(node1); }
-        lock (s1) { s1.Push(node2); }
-        lock (s1) { s1.TryPop(out _); }
-        lock (s1) { s1.TryPop(out _); }
-    }
-
-    [Benchmark]
-    public void ConcurrentQueue()
-    {
-        cq.Enqueue(node1);
-        cq.Enqueue(node1);
-        cq.TryDequeue(out _);
-        cq.TryDequeue(out _);
-    }
-
-    [Benchmark]
-    public void ConcurrentStack()
-    {
-        cs.Push(node1);
-        cs.Push(node2);
-        cs.TryPop(out _);
-        cs.TryPop(out _);
-    }
-
-    [Benchmark]
-    public void TaskPool()
-    {
-        pool.TryPush(node1);
-        pool.TryPush(node2);
-        pool.TryPop(out _);
-        pool.TryPop(out _);
-    }
-    [Benchmark]
-    public void TaskPoolRefNode()
-    {
-        poolRefNode.TryPush(refNode1);
-        poolRefNode.TryPush(refNode2);
-        poolRefNode.TryPop(out _);
-        poolRefNode.TryPop(out _);
-    }
-
-    [Benchmark]
-    public void TaskPoolEqualNull()
-    {
-        poolEqualNull.TryPush(node1);
-        poolEqualNull.TryPush(node2);
-        poolEqualNull.TryPop(out _);
-        poolEqualNull.TryPop(out _);
-    }
-
-    [Benchmark]
-    public void TaskPoolClass()
-    {
-        poolClass.TryPush(node1);
-        poolClass.TryPush(node2);
-        poolClass.TryPop(out _);
-        poolClass.TryPop(out _);
-    }
-
-    [Benchmark]
-    public void TaskPoolWithoutSize()
-    {
-        poolWithoutSize.TryPush(node1);
-        poolWithoutSize.TryPush(node2);
-        poolWithoutSize.TryPop(out _);
-        poolWithoutSize.TryPop(out _);
-    }
-
-    [Benchmark]
-    public void TaskPoolWithoutLock()
-    {
-        poolWithoutLock.TryPush(node1);
-        poolWithoutLock.TryPush(node2);
-        poolWithoutLock.TryPop(out _);
-        poolWithoutLock.TryPop(out _);
-    }
-}
-
-public sealed class Node : ITaskPoolNode<Node>
-{
-    public Node NextNode { get; set; }
-}
-
-public interface ITaskPoolNode<T>
-{
-    T NextNode { get; set; }
-}
-
-public sealed class RefNode :ITaskPoolRefNode<RefNode>
-{
-    RefNode nextNode;
-    public ref RefNode NextNode => ref nextNode;
-}
-
-public interface ITaskPoolRefNode<T>
-{
-    ref T NextNode { get; }
-}
-
-
-// mutable struct, don't mark readonly.
-[StructLayout(LayoutKind.Auto)]
-public struct TaskPoolWithoutLock<T>
-    where T : class, ITaskPoolNode<T>
-{
-    int size;
-    T root;
-
-    public int Size => size;
-
-    [MethodImpl(MethodImplOptions.AggressiveInlining)]
-    public bool TryPop(out T result)
-    {
-        //if (Interlocked.CompareExchange(ref gate, 1, 0) == 0)
-        {
-            var v = root;
-            if (!(v is null))
-            {
-                root = v.NextNode;
-                v.NextNode = null;
-                size--;
-                result = v;
-                //      Volatile.Write(ref gate, 0);
-                return true;
-            }
-
-            //Volatile.Write(ref gate, 0);
-        }
-        result = default;
-        return false;
-    }
-
-    [MethodImpl(MethodImplOptions.AggressiveInlining)]
-    public bool TryPush(T item)
-    {
-        //if (Interlocked.CompareExchange(ref gate, 1, 0) == 0)
-        {
-            //if (size < TaskPool.MaxPoolSize)
-            {
-                item.NextNode = root;
-                root = item;
-                size++;
-                //      Volatile.Write(ref gate, 0);
-                return true;
-            }
-            //else
-            {
-                //  Volatile.Write(ref gate, 0);
-            }
-        }
-        //return false;
-    }
-}
-
-[StructLayout(LayoutKind.Auto)]
-public struct TaskPool<T>
-    where T : class, ITaskPoolNode<T>
-{
-    int gate;
-    int size;
-    T root;
-
-    public int Size => size;
-
-    [MethodImpl(MethodImplOptions.AggressiveInlining)]
-    public bool TryPop(out T result)
-    {
-        if (Interlocked.CompareExchange(ref gate, 1, 0) == 0)
-        {
-            var v = root;
-            if (!(v is null))
-            {
-                root = v.NextNode;
-                v.NextNode = null;
-                size--;
-                result = v;
-                Volatile.Write(ref gate, 0);
-                return true;
-            }
-
-            Volatile.Write(ref gate, 0);
-        }
-        result = default;
-        return false;
-    }
-
-    [MethodImpl(MethodImplOptions.AggressiveInlining)]
-    public bool TryPush(T item)
-    {
-        if (Interlocked.CompareExchange(ref gate, 1, 0) == 0)
-        {
-            //if (size < TaskPool.MaxPoolSize)
-            {
-                item.NextNode = root;
-                root = item;
-                size++;
-                Volatile.Write(ref gate, 0);
-                return true;
-            }
-            //else
-            {
-                //  Volatile.Write(ref gate, 0);
-            }
-        }
-        return false;
-    }
-}
-[StructLayout(LayoutKind.Auto)]
-public struct TaskPoolRefNode<T>
-    where T : class, ITaskPoolRefNode<T>
-{
-    int gate;
-    int size;
-    T root;
-
-    public int Size => size;
-
-    [MethodImpl(MethodImplOptions.AggressiveInlining)]
-    public bool TryPop(out T result)
-    {
-        if (Interlocked.CompareExchange(ref gate, 1, 0) == 0)
-        {
-            var v = root;
-            if (!(v is null))
-            {
-                ref var nextNode = ref v.NextNode;
-                root = nextNode;
-                nextNode = null;
-                size--;
-                result = v;
-                Volatile.Write(ref gate, 0);
-                return true;
-            }
-
-            Volatile.Write(ref gate, 0);
-        }
-        result = default;
-        return false;
-    }
-
-    [MethodImpl(MethodImplOptions.AggressiveInlining)]
-    public bool TryPush(T item)
-    {
-        if (Interlocked.CompareExchange(ref gate, 1, 0) == 0)
-        {
-            //if (size < TaskPool.MaxPoolSize)
-            {
-                item.NextNode = root;
-                root = item;
-                size++;
-                Volatile.Write(ref gate, 0);
-                return true;
-            }
-            //else
-            {
-                //  Volatile.Write(ref gate, 0);
-            }
-        }
-        return false;
-    }
-}
-
-[StructLayout(LayoutKind.Auto)]
-public struct TaskPoolEqualNull<T>
-    where T : class, ITaskPoolNode<T>
-{
-    int gate;
-    int size;
-    T root;
-
-    public int Size => size;
-
-    [MethodImpl(MethodImplOptions.AggressiveInlining)]
-    public bool TryPop(out T result)
-    {
-        if (Interlocked.CompareExchange(ref gate, 1, 0) == 0)
-        {
-            var v = root;
-            if (v != null)
-            {
-                root = v.NextNode;
-                v.NextNode = null;
-                size--;
-                result = v;
-                Volatile.Write(ref gate, 0);
-                return true;
-            }
-
-            Volatile.Write(ref gate, 0);
-        }
-        result = default;
-        return false;
-    }
-
-    [MethodImpl(MethodImplOptions.AggressiveInlining)]
-    public bool TryPush(T item)
-    {
-        if (Interlocked.CompareExchange(ref gate, 1, 0) == 0)
-        {
-            //if (size < TaskPool.MaxPoolSize)
-            {
-                item.NextNode = root;
-                root = item;
-                size++;
-                Volatile.Write(ref gate, 0);
-                return true;
-            }
-            //else
-            {
-                //  Volatile.Write(ref gate, 0);
-            }
-        }
-        return false;
-    }
-}
-
-public class TaskPoolClass<T>
-    where T : class, ITaskPoolNode<T>
-{
-    int gate;
-    int size;
-    T root;
-
-    public int Size => size;
-
-    [MethodImpl(MethodImplOptions.AggressiveInlining)]
-    public bool TryPop(out T result)
-    {
-        if (Interlocked.CompareExchange(ref gate, 1, 0) == 0)
-        {
-            var v = root;
-            if (!(v is null))
-            {
-                root = v.NextNode;
-                v.NextNode = null;
-                size--;
-                result = v;
-                Volatile.Write(ref gate, 0);
-                return true;
-            }
-
-            Volatile.Write(ref gate, 0);
-        }
-        result = default;
-        return false;
-    }
-
-    [MethodImpl(MethodImplOptions.AggressiveInlining)]
-    public bool TryPush(T item)
-    {
-        if (Interlocked.CompareExchange(ref gate, 1, 0) == 0)
-        {
-            //if (size < TaskPool.MaxPoolSize)
-            {
-                item.NextNode = root;
-                root = item;
-                size++;
-                Volatile.Write(ref gate, 0);
-                return true;
-            }
-            //else
-            {
-                //  Volatile.Write(ref gate, 0);
-            }
-        }
-        return false;
-    }
-}
-
-[StructLayout(LayoutKind.Auto)]
-public struct TaskPoolWithoutSize<T>
-    where T : class, ITaskPoolNode<T>
-{
-    int gate;
-    T root;
-
-
-    [MethodImpl(MethodImplOptions.AggressiveInlining)]
-    public bool TryPop(out T result)
-    {
-        if (Interlocked.CompareExchange(ref gate, 1, 0) == 0)
-        {
-            var v = root;
-            if (!(v is null))
-            {
-                root = v.NextNode;
-                v.NextNode = null;
-                result = v;
-                Volatile.Write(ref gate, 0);
-                return true;
-            }
-
-            Volatile.Write(ref gate, 0);
-        }
-        result = default;
-        return false;
-    }
-
-    [MethodImpl(MethodImplOptions.AggressiveInlining)]
-    public bool TryPush(T item)
-    {
-        if (Interlocked.CompareExchange(ref gate, 1, 0) == 0)
-        {
-            //if (size < TaskPool.MaxPoolSize)
-            {
-                item.NextNode = root;
-                root = item;
-                Volatile.Write(ref gate, 0);
-                return true;
-            }
-            //else
-            {
-                //  Volatile.Write(ref gate, 0);
-            }
-        }
-        return false;
-    }
-}

src/UniTask.NetCoreSandbox/UniTask.NetCoreSandbox.csproj

@@ -15,6 +15,12 @@
 
   <ItemGroup>
     <ProjectReference Include="..\UniTask.NetCore\UniTask.NetCore.csproj" />
+
+
+      <ProjectReference Include="..\UniTask.Analyzer\UniTask.Analyzer.csproj">
+          <ReferenceOutputAssembly>false</ReferenceOutputAssembly>
+          <OutputItemType>Analyzer</OutputItemType>
+      </ProjectReference>
   </ItemGroup>
 
 </Project>

src/UniTask/Assets/Editor/EditorRunnerChecker.cs

@@ -22,7 +22,9 @@ public static class EditorRunnerChecker
 
         //var r = await UnityWebRequest.Get("https://bing.com/").SendWebRequest().ToUniTask();
         //Debug.Log(r.downloadHandler.text.Substring(0, 100));
-        await UniTask.Yield();
+        //await UniTask.Yield();
+
+        await UniTask.DelayFrame(30);
 
         Debug.Log("End");
     }

src/UniTask/Assets/Plugins/UniTask/Runtime/External/DOTween/DOTweenAsyncExtensions.cs

@@ -16,14 +16,14 @@ namespace Cysharp.Threading.Tasks
         Kill,
         KillWithCompleteCallback,
         Complete,
-        CompleteWithSeqeunceCallback,
+        CompleteWithSequenceCallback,
         CancelAwait,
 
         // AndCancelAwait
         KillAndCancelAwait,
         KillWithCompleteCallbackAndCancelAwait,
         CompleteAndCancelAwait,
-        CompleteWithSeqeunceCallbackAndCancelAwait
+        CompleteWithSequenceCallbackAndCancelAwait
     }
 
     public static class DOTweenAsyncExtensions
@@ -143,8 +143,6 @@ namespace Cysharp.Threading.Tasks
                 TaskPool.RegisterSizeGetter(typeof(TweenConfiguredSource), () => pool.Size);
             }
 
-            static readonly TweenCallback EmptyTweenCallback = () => { };
-
             readonly TweenCallback onCompleteCallbackDelegate;
             readonly TweenCallback onUpdateDelegate;
 
@@ -155,6 +153,7 @@ namespace Cysharp.Threading.Tasks
             bool canceled;
 
             TweenCallback originalUpdateAction;
+            TweenCallback originalCompleteAction;
             UniTaskCompletionSourceCore<AsyncUnit> core;
 
             TweenConfiguredSource()
@@ -194,27 +193,38 @@ namespace Cysharp.Threading.Tasks
                 switch (callbackType)
                 {
                     case CallbackType.Kill:
+                        result.originalCompleteAction = tween.onKill;
                         tween.onKill = result.onCompleteCallbackDelegate;
                         break;
                     case CallbackType.Complete:
+                        result.originalCompleteAction = tween.onComplete;
                         tween.onComplete = result.onCompleteCallbackDelegate;
                         break;
                     case CallbackType.Pause:
+                        result.originalCompleteAction = tween.onPause;
                         tween.onPause = result.onCompleteCallbackDelegate;
                         break;
                     case CallbackType.Play:
+                        result.originalCompleteAction = tween.onPlay;
                         tween.onPlay = result.onCompleteCallbackDelegate;
                         break;
                     case CallbackType.Rewind:
+                        result.originalCompleteAction = tween.onRewind;
                         tween.onRewind = result.onCompleteCallbackDelegate;
                         break;
                     case CallbackType.StepComplete:
+                        result.originalCompleteAction = tween.onStepComplete;
                         tween.onStepComplete = result.onCompleteCallbackDelegate;
                         break;
                     default:
                         break;
                 }
 
+                if (result.originalCompleteAction == result.onCompleteCallbackDelegate)
+                {
+                    result.originalCompleteAction = null;
+                }
+
                 TaskTracker.TrackActiveTask(result, 3);
 
                 token = result.core.Version;
@@ -228,7 +238,7 @@ namespace Cysharp.Threading.Tasks
                     if (this.cancelBehaviour == TweenCancelBehaviour.KillAndCancelAwait
                         || this.cancelBehaviour == TweenCancelBehaviour.KillWithCompleteCallbackAndCancelAwait
                         || this.cancelBehaviour == TweenCancelBehaviour.CompleteAndCancelAwait
-                        || this.cancelBehaviour == TweenCancelBehaviour.CompleteWithSeqeunceCallbackAndCancelAwait
+                        || this.cancelBehaviour == TweenCancelBehaviour.CompleteWithSequenceCallbackAndCancelAwait
                         || this.cancelBehaviour == TweenCancelBehaviour.CancelAwait)
                     {
                         canceled = true;
@@ -240,6 +250,7 @@ namespace Cysharp.Threading.Tasks
                 }
                 else
                 {
+                    originalCompleteAction?.Invoke();
                     core.TrySetResult(AsyncUnit.Default);
                 }
             }
@@ -277,34 +288,34 @@ namespace Cysharp.Threading.Tasks
                         this.canceled = true;
                         this.tween.Complete(false);
                         break;
-                    case TweenCancelBehaviour.CompleteWithSeqeunceCallback:
+                    case TweenCancelBehaviour.CompleteWithSequenceCallback:
                         this.tween.Complete(true);
                         break;
-                    case TweenCancelBehaviour.CompleteWithSeqeunceCallbackAndCancelAwait:
+                    case TweenCancelBehaviour.CompleteWithSequenceCallbackAndCancelAwait:
                         this.canceled = true;
                         this.tween.Complete(true);
                         break;
                     case TweenCancelBehaviour.CancelAwait:
-                        // replace to empty(avoid callback after Canceled(instance is returned to pool.)
+                        // restore to original callback
                         switch (callbackType)
                         {
                             case CallbackType.Kill:
-                                tween.onKill = EmptyTweenCallback;
+                                tween.onKill = originalCompleteAction;
                                 break;
                             case CallbackType.Complete:
-                                tween.onComplete = EmptyTweenCallback;
+                                tween.onComplete = originalCompleteAction;
                                 break;
                             case CallbackType.Pause:
-                                tween.onPause = EmptyTweenCallback;
+                                tween.onPause = originalCompleteAction;
                                 break;
                             case CallbackType.Play:
-                                tween.onPlay = EmptyTweenCallback;
+                                tween.onPlay = originalCompleteAction;
                                 break;
                             case CallbackType.Rewind:
-                                tween.onRewind = EmptyTweenCallback;
+                                tween.onRewind = originalCompleteAction;
                                 break;
                             case CallbackType.StepComplete:
-                                tween.onStepComplete = EmptyTweenCallback;
+                                tween.onStepComplete = originalCompleteAction;
                                 break;
                             default:
                                 break;
@@ -339,10 +350,10 @@ namespace Cysharp.Threading.Tasks
                     case TweenCancelBehaviour.CompleteAndCancelAwait:
                         tween.Complete(false);
                         break;
-                    case TweenCancelBehaviour.CompleteWithSeqeunceCallback:
+                    case TweenCancelBehaviour.CompleteWithSequenceCallback:
                         tween.Complete(true);
                         break;
-                    case TweenCancelBehaviour.CompleteWithSeqeunceCallbackAndCancelAwait:
+                    case TweenCancelBehaviour.CompleteWithSequenceCallbackAndCancelAwait:
                         tween.Complete(true);
                         break;
                     case TweenCancelBehaviour.CancelAwait:
@@ -386,22 +397,22 @@ namespace Cysharp.Threading.Tasks
                 switch (callbackType)
                 {
                     case CallbackType.Kill:
-                        tween.onKill = null;
+                        tween.onKill = originalCompleteAction;
                         break;
                     case CallbackType.Complete:
-                        tween.onComplete = null;
+                        tween.onComplete = originalCompleteAction;
                         break;
                     case CallbackType.Pause:
-                        tween.onPause = null;
+                        tween.onPause = originalCompleteAction;
                         break;
                     case CallbackType.Play:
-                        tween.onPlay = null;
+                        tween.onPlay = originalCompleteAction;
                         break;
                     case CallbackType.Rewind:
-                        tween.onRewind = null;
+                        tween.onRewind = originalCompleteAction;
                         break;
                     case CallbackType.StepComplete:
-                        tween.onStepComplete = null;
+                        tween.onStepComplete = originalCompleteAction;
                         break;
                     default:
                         break;
@@ -410,6 +421,7 @@ namespace Cysharp.Threading.Tasks
                 tween = default;
                 cancellationToken = default;
                 originalUpdateAction = default;
+                originalCompleteAction = default;
                 return pool.TryPush(this);
             }
         }

src/UniTask/Assets/Plugins/UniTask/Runtime/Internal/DiagnosticsExtensions.cs

@@ -148,7 +148,7 @@ namespace Cysharp.Threading.Tasks.Internal
 
             foreach (var candidateMethod in methods)
             {
-                var attributes = candidateMethod.GetCustomAttributes<StateMachineAttribute>();
+                var attributes = candidateMethod.GetCustomAttributes<StateMachineAttribute>(false);
                 if (attributes == null)
                 {
                     continue;

src/UniTask/Assets/Plugins/UniTask/Runtime/UniTask.Delay.cs

@@ -2,6 +2,7 @@
 
 using Cysharp.Threading.Tasks.Internal;
 using System;
+using System.Collections;
 using System.Runtime.CompilerServices;
 using System.Threading;
 using UnityEngine;
@@ -74,23 +75,24 @@ namespace Cysharp.Threading.Tasks
             return new UniTask(NextFramePromise.Create(timing, cancellationToken, out var token), token);
         }
 
-
+        [Obsolete("Use WaitForEndOfFrame(MonoBehaviour) instead or UniTask.Yield(PlayerLoopTiming.LastPostLateUpdate). Equivalent for coroutine's WaitForEndOfFrame requires MonoBehaviour(runner of Coroutine).")]
-        /// <summary>
-        /// Same as UniTask.Yield(PlayerLoopTiming.LastPostLateUpdate).
-        /// </summary>
         public static YieldAwaitable WaitForEndOfFrame()
         {
             return UniTask.Yield(PlayerLoopTiming.LastPostLateUpdate);
         }
 
-        /// <summary>
+        [Obsolete("Use WaitForEndOfFrame(MonoBehaviour) instead or UniTask.Yield(PlayerLoopTiming.LastPostLateUpdate). Equivalent for coroutine's WaitForEndOfFrame requires MonoBehaviour(runner of Coroutine).")]
-        /// Same as UniTask.Yield(PlayerLoopTiming.LastPostLateUpdate, cancellationToken).
-        /// </summary>
         public static UniTask WaitForEndOfFrame(CancellationToken cancellationToken)
         {
             return UniTask.Yield(PlayerLoopTiming.LastPostLateUpdate, cancellationToken);
         }
 
+        public static UniTask WaitForEndOfFrame(MonoBehaviour coroutineRunner, CancellationToken cancellationToken = default)
+        {
+            var source = WaitForEndOfFramePromise.Create(coroutineRunner, cancellationToken, out var token);
+            return new UniTask(source, token);
+        }
+
         /// <summary>
         /// Same as UniTask.Yield(PlayerLoopTiming.FixedUpdate).
         /// </summary>
@@ -352,6 +354,113 @@ namespace Cysharp.Threading.Tasks
             }
         }
 
+        sealed class WaitForEndOfFramePromise : IUniTaskSource, ITaskPoolNode<WaitForEndOfFramePromise>, System.Collections.IEnumerator
+        {
+            static TaskPool<WaitForEndOfFramePromise> pool;
+            WaitForEndOfFramePromise nextNode;
+            public ref WaitForEndOfFramePromise NextNode => ref nextNode;
+
+            static WaitForEndOfFramePromise()
+            {
+                TaskPool.RegisterSizeGetter(typeof(WaitForEndOfFramePromise), () => pool.Size);
+            }
+
+            CancellationToken cancellationToken;
+            UniTaskCompletionSourceCore<object> core;
+
+            WaitForEndOfFramePromise()
+            {
+            }
+
+            public static IUniTaskSource Create(MonoBehaviour coroutineRunner, CancellationToken cancellationToken, out short token)
+            {
+                if (cancellationToken.IsCancellationRequested)
+                {
+                    return AutoResetUniTaskCompletionSource.CreateFromCanceled(cancellationToken, out token);
+                }
+
+                if (!pool.TryPop(out var result))
+                {
+                    result = new WaitForEndOfFramePromise();
+                }
+
+                result.cancellationToken = cancellationToken;
+
+                TaskTracker.TrackActiveTask(result, 3);
+
+                coroutineRunner.StartCoroutine(result);
+
+                token = result.core.Version;
+                return result;
+            }
+
+            public void GetResult(short token)
+            {
+                try
+                {
+                    core.GetResult(token);
+                }
+                finally
+                {
+                    TryReturn();
+                }
+            }
+
+            public UniTaskStatus GetStatus(short token)
+            {
+                return core.GetStatus(token);
+            }
+
+            public UniTaskStatus UnsafeGetStatus()
+            {
+                return core.UnsafeGetStatus();
+            }
+
+            public void OnCompleted(Action<object> continuation, object state, short token)
+            {
+                core.OnCompleted(continuation, state, token);
+            }
+
+            bool TryReturn()
+            {
+                TaskTracker.RemoveTracking(this);
+                core.Reset();
+                Reset(); // Reset Enumerator
+                cancellationToken = default;
+                return pool.TryPush(this);
+            }
+
+            // Coroutine Runner implementation
+
+            static readonly WaitForEndOfFrame waitForEndOfFrameYieldInstruction = new WaitForEndOfFrame();
+            bool isFirst = true;
+
+            object IEnumerator.Current => waitForEndOfFrameYieldInstruction;
+
+            bool IEnumerator.MoveNext()
+            {
+                if (isFirst)
+                {
+                    isFirst = false;
+                    return true; // start WaitForEndOfFrame
+                }
+
+                if (cancellationToken.IsCancellationRequested)
+                {
+                    core.TrySetCanceled(cancellationToken);
+                    return false;
+                }
+
+                core.TrySetResult(null);
+                return false;
+            }
+
+            public void Reset()
+            {
+                isFirst = true;
+            }
+        }
+
         sealed class DelayFramePromise : IUniTaskSource, IPlayerLoopItem, ITaskPoolNode<DelayFramePromise>
         {
             static TaskPool<DelayFramePromise> pool;
@@ -444,7 +553,19 @@ namespace Cysharp.Threading.Tasks
                     // skip in initial frame.
                     if (initialFrame == Time.frameCount)
                     {
+#if UNITY_EDITOR
+                        // force use Realtime.
+                        if (PlayerLoopHelper.IsMainThread && !UnityEditor.EditorApplication.isPlaying)
+                        {
+                            //goto ++currentFrameCount
+                        }
+                        else
+                        {
+                            return true;
+                        }
+#else
                         return true;
+#endif
                     }
                 }
 

src/UniTask/Assets/Plugins/UniTask/Runtime/UniTask.Factory.cs

@@ -194,6 +194,7 @@ namespace Cysharp.Threading.Tasks
         sealed class ExceptionResultSource : IUniTaskSource
         {
             readonly ExceptionDispatchInfo exception;
+            bool calledGet;
 
             public ExceptionResultSource(Exception exception)
             {
@@ -202,6 +203,11 @@ namespace Cysharp.Threading.Tasks
 
             public void GetResult(short token)
             {
+                if (!calledGet)
+                {
+                    calledGet = true;
+                    GC.SuppressFinalize(this);
+                }
                 exception.Throw();
             }
 
@@ -219,11 +225,20 @@ namespace Cysharp.Threading.Tasks
             {
                 continuation(state);
             }
+
+            ~ExceptionResultSource()
+            {
+                if (!calledGet)
+                {
+                    UniTaskScheduler.PublishUnobservedTaskException(exception.SourceException);
+                }
+            }
         }
 
         sealed class ExceptionResultSource<T> : IUniTaskSource<T>
         {
             readonly ExceptionDispatchInfo exception;
+            bool calledGet;
 
             public ExceptionResultSource(Exception exception)
             {
@@ -232,12 +247,22 @@ namespace Cysharp.Threading.Tasks
 
             public T GetResult(short token)
             {
+                if (!calledGet)
+                {
+                    calledGet = true;
+                    GC.SuppressFinalize(this);
+                }
                 exception.Throw();
                 return default;
             }
 
             void IUniTaskSource.GetResult(short token)
             {
+                if (!calledGet)
+                {
+                    calledGet = true;
+                    GC.SuppressFinalize(this);
+                }
                 exception.Throw();
             }
 
@@ -255,6 +280,14 @@ namespace Cysharp.Threading.Tasks
             {
                 continuation(state);
             }
+
+            ~ExceptionResultSource()
+            {
+                if (!calledGet)
+                {
+                    UniTaskScheduler.PublishUnobservedTaskException(exception.SourceException);
+                }
+            }
         }
 
         sealed class CanceledResultSource : IUniTaskSource

src/UniTask/Assets/Plugins/UniTask/Runtime/UniTask.Run.cs

@@ -9,237 +9,56 @@ namespace Cysharp.Threading.Tasks
     {
         #region OBSOLETE_RUN
 
-        // Run is a confusing name, use only RunOnThreadPool in the future.
+        [Obsolete("UniTask.Run is similar as Task.Run, it uses ThreadPool. For equivalent behaviour, use UniTask.RunOnThreadPool instead. If you don't want to use ThreadPool, you can use UniTask.Void(async void) or UniTask.Create(async UniTask) too.")]
-
+        public static UniTask Run(Action action, bool configureAwait = true, CancellationToken cancellationToken = default)
-        /// <summary>[Obsolete]recommend to use RunOnThreadPool(or UniTask.Void(async void), UniTask.Create(async UniTask)).</summary>
-        public static async UniTask Run(Action action, bool configureAwait = true, CancellationToken cancellationToken = default)
         {
-            cancellationToken.ThrowIfCancellationRequested();
+            return RunOnThreadPool(action, configureAwait, cancellationToken);
-
-            await UniTask.SwitchToThreadPool();
-
-            cancellationToken.ThrowIfCancellationRequested();
-
-            if (configureAwait)
-            {
-                try
-                {
-                    action();
-                }
-                finally
-                {
-                    await UniTask.Yield();
-                }
-            }
-            else
-            {
-                action();
-            }
-
-            cancellationToken.ThrowIfCancellationRequested();
         }
 
-        /// <summary>[Obsolete]recommend to use RunOnThreadPool(or UniTask.Void(async void), UniTask.Create(async UniTask)).</summary>
+        [Obsolete("UniTask.Run is similar as Task.Run, it uses ThreadPool. For equivalent behaviour, use UniTask.RunOnThreadPool instead. If you don't want to use ThreadPool, you can use UniTask.Void(async void) or UniTask.Create(async UniTask) too.")]
-        public static async UniTask Run(Action<object> action, object state, bool configureAwait = true, CancellationToken cancellationToken = default)
+        public static UniTask Run(Action<object> action, object state, bool configureAwait = true, CancellationToken cancellationToken = default)
         {
-            cancellationToken.ThrowIfCancellationRequested();
+            return RunOnThreadPool(action, state, configureAwait, cancellationToken);
-
-            await UniTask.SwitchToThreadPool();
-
-            cancellationToken.ThrowIfCancellationRequested();
-
-            if (configureAwait)
-            {
-                try
-                {
-                    action(state);
-                }
-                finally
-                {
-                    await UniTask.Yield();
-                }
-            }
-            else
-            {
-                action(state);
-            }
-
-            cancellationToken.ThrowIfCancellationRequested();
         }
 
-        /// <summary>[Obsolete]recommend to use RunOnThreadPool(or UniTask.Void(async void), UniTask.Create(async UniTask)).</summary>
+        [Obsolete("UniTask.Run is similar as Task.Run, it uses ThreadPool. For equivalent behaviour, use UniTask.RunOnThreadPool instead. If you don't want to use ThreadPool, you can use UniTask.Void(async void) or UniTask.Create(async UniTask) too.")]
-        public static async UniTask Run(Func<UniTask> action, bool configureAwait = true, CancellationToken cancellationToken = default)
+        public static UniTask Run(Func<UniTask> action, bool configureAwait = true, CancellationToken cancellationToken = default)
         {
-            cancellationToken.ThrowIfCancellationRequested();
+            return RunOnThreadPool(action, configureAwait, cancellationToken);
-
-            await UniTask.SwitchToThreadPool();
-
-            cancellationToken.ThrowIfCancellationRequested();
-
-            if (configureAwait)
-            {
-                try
-                {
-                    await action();
-                }
-                finally
-                {
-                    await UniTask.Yield();
-                }
-            }
-            else
-            {
-                await action();
-            }
-
-            cancellationToken.ThrowIfCancellationRequested();
         }
 
-        /// <summary>[Obsolete]recommend to use RunOnThreadPool(or UniTask.Void(async void), UniTask.Create(async UniTask)).</summary>
+        [Obsolete("UniTask.Run is similar as Task.Run, it uses ThreadPool. For equivalent behaviour, use UniTask.RunOnThreadPool instead. If you don't want to use ThreadPool, you can use UniTask.Void(async void) or UniTask.Create(async UniTask) too.")]
-        public static async UniTask Run(Func<object, UniTask> action, object state, bool configureAwait = true, CancellationToken cancellationToken = default)
+        public static UniTask Run(Func<object, UniTask> action, object state, bool configureAwait = true, CancellationToken cancellationToken = default)
         {
-            cancellationToken.ThrowIfCancellationRequested();
+            return RunOnThreadPool(action, state, configureAwait, cancellationToken);
-
-            await UniTask.SwitchToThreadPool();
-
-            cancellationToken.ThrowIfCancellationRequested();
-
-            if (configureAwait)
-            {
-                try
-                {
-                    await action(state);
-                }
-                finally
-                {
-                    await UniTask.Yield();
-                }
-            }
-            else
-            {
-                await action(state);
-            }
-
-            cancellationToken.ThrowIfCancellationRequested();
         }
 
-        /// <summary>[Obsolete]recommend to use RunOnThreadPool(or UniTask.Void(async void), UniTask.Create(async UniTask)).</summary>
+        [Obsolete("UniTask.Run is similar as Task.Run, it uses ThreadPool. For equivalent behaviour, use UniTask.RunOnThreadPool instead. If you don't want to use ThreadPool, you can use UniTask.Void(async void) or UniTask.Create(async UniTask) too.")]
-        public static async UniTask<T> Run<T>(Func<T> func, bool configureAwait = true, CancellationToken cancellationToken = default)
+        public static UniTask<T> Run<T>(Func<T> func, bool configureAwait = true, CancellationToken cancellationToken = default)
         {
-            cancellationToken.ThrowIfCancellationRequested();
+            return RunOnThreadPool(func, configureAwait, cancellationToken);
-
-            await UniTask.SwitchToThreadPool();
-
-            cancellationToken.ThrowIfCancellationRequested();
-
-            if (configureAwait)
-            {
-                try
-                {
-                    return func();
-                }
-                finally
-                {
-                    await UniTask.Yield();
-                    cancellationToken.ThrowIfCancellationRequested();
-                }
-            }
-            else
-            {
-                return func();
-            }
         }
 
-        /// <summary>[Obsolete]recommend to use RunOnThreadPool(or UniTask.Void(async void), UniTask.Create(async UniTask)).</summary>
+        [Obsolete("UniTask.Run is similar as Task.Run, it uses ThreadPool. For equivalent behaviour, use UniTask.RunOnThreadPool instead. If you don't want to use ThreadPool, you can use UniTask.Void(async void) or UniTask.Create(async UniTask) too.")]
-        public static async UniTask<T> Run<T>(Func<UniTask<T>> func, bool configureAwait = true, CancellationToken cancellationToken = default)
+        public static UniTask<T> Run<T>(Func<UniTask<T>> func, bool configureAwait = true, CancellationToken cancellationToken = default)
         {
-            cancellationToken.ThrowIfCancellationRequested();
+            return RunOnThreadPool(func, configureAwait, cancellationToken);
-
-            await UniTask.SwitchToThreadPool();
-
-            cancellationToken.ThrowIfCancellationRequested();
-
-            if (configureAwait)
-            {
-                try
-                {
-                    return await func();
-                }
-                finally
-                {
-                    cancellationToken.ThrowIfCancellationRequested();
-                    await UniTask.Yield();
-                    cancellationToken.ThrowIfCancellationRequested();
-                }
-            }
-            else
-            {
-                var result = await func();
-                cancellationToken.ThrowIfCancellationRequested();
-                return result;
-            }
         }
 
-        /// <summary>[Obsolete]recommend to use RunOnThreadPool(or UniTask.Void(async void), UniTask.Create(async UniTask)).</summary>
+        [Obsolete("UniTask.Run is similar as Task.Run, it uses ThreadPool. For equivalent behaviour, use UniTask.RunOnThreadPool instead. If you don't want to use ThreadPool, you can use UniTask.Void(async void) or UniTask.Create(async UniTask) too.")]
-        public static async UniTask<T> Run<T>(Func<object, T> func, object state, bool configureAwait = true, CancellationToken cancellationToken = default)
+        public static UniTask<T> Run<T>(Func<object, T> func, object state, bool configureAwait = true, CancellationToken cancellationToken = default)
         {
-            cancellationToken.ThrowIfCancellationRequested();
+            return RunOnThreadPool(func, state, configureAwait, cancellationToken);
-
-            await UniTask.SwitchToThreadPool();
-
-            cancellationToken.ThrowIfCancellationRequested();
-
-            if (configureAwait)
-            {
-                try
-                {
-                    return func(state);
-                }
-                finally
-                {
-                    await UniTask.Yield();
-                    cancellationToken.ThrowIfCancellationRequested();
-                }
-            }
-            else
-            {
-                return func(state);
-            }
         }
 
-        /// <summary>[Obsolete]recommend to use RunOnThreadPool(or UniTask.Void(async void), UniTask.Create(async UniTask)).</summary>
+        [Obsolete("UniTask.Run is similar as Task.Run, it uses ThreadPool. For equivalent behaviour, use UniTask.RunOnThreadPool instead. If you don't want to use ThreadPool, you can use UniTask.Void(async void) or UniTask.Create(async UniTask) too.")]
-        public static async UniTask<T> Run<T>(Func<object, UniTask<T>> func, object state, bool configureAwait = true, CancellationToken cancellationToken = default)
+        public static UniTask<T> Run<T>(Func<object, UniTask<T>> func, object state, bool configureAwait = true, CancellationToken cancellationToken = default)
         {
-            cancellationToken.ThrowIfCancellationRequested();
+            return RunOnThreadPool(func, state, configureAwait, cancellationToken);
-
-            await UniTask.SwitchToThreadPool();
-
-            cancellationToken.ThrowIfCancellationRequested();
-
-            if (configureAwait)
-            {
-                try
-                {
-                    return await func(state);
-                }
-                finally
-                {
-                    cancellationToken.ThrowIfCancellationRequested();
-                    await UniTask.Yield();
-                    cancellationToken.ThrowIfCancellationRequested();
-                }
-            }
-            else
-            {
-                var result = await func(state);
-                cancellationToken.ThrowIfCancellationRequested();
-                return result;
-            }
         }
 
         #endregion
 
-
         /// <summary>Run action on the threadPool and return to main thread if configureAwait = true.</summary>
         public static async UniTask RunOnThreadPool(Action action, bool configureAwait = true, CancellationToken cancellationToken = default)
         {

src/UniTask/Assets/Plugins/UniTask/Runtime/UniTaskObservableExtensions.cs

@@ -74,16 +74,19 @@ namespace Cysharp.Threading.Tasks
 
         static async UniTaskVoid Fire<T>(AsyncSubject<T> subject, UniTask<T> task)
         {
+            T value;
             try
             {
-                var value = await task;
+                value = await task;
-                subject.OnNext(value);
-                subject.OnCompleted();
             }
             catch (Exception ex)
             {
                 subject.OnError(ex);
+                return;
             }
+
+            subject.OnNext(value);
+            subject.OnCompleted();
         }
 
         static async UniTaskVoid Fire(AsyncSubject<AsyncUnit> subject, UniTask task)
@@ -91,13 +94,15 @@ namespace Cysharp.Threading.Tasks
             try
             {
                 await task;
-                subject.OnNext(AsyncUnit.Default);
-                subject.OnCompleted();
             }
             catch (Exception ex)
             {
                 subject.OnError(ex);
+                return;
             }
+
+            subject.OnNext(AsyncUnit.Default);
+            subject.OnCompleted();
         }
 
         class ToUniTaskObserver<T> : IObserver<T>

src/UniTask/Assets/Plugins/UniTask/package.json

@@ -1,11 +1,12 @@
 {
     "name": "com.cysharp.unitask",
     "displayName": "UniTask",
-    "version": "2.2.5",
+    "author": { "name": "Cysharp, Inc.", "url": "https://cysharp.co.jp/en/" },
+    "version": "2.3.1",
     "unity": "2018.4",
     "description": "Provides an efficient async/await integration to Unity.",
     "keywords": [ "async/await", "async", "Task", "UniTask" ],
     "license": "MIT",
     "category": "Task",
     "dependencies": {}
-}
+}

src/UniTask/Assets/Scenes/SandboxMain.cs

@@ -543,7 +543,7 @@ public class SandboxMain : MonoBehaviour
                 Debug.LogError(e);
                 return;
 
-                
+
             }
         }
         Debug.Log("TestAsync Finished.");
@@ -555,6 +555,7 @@ public class SandboxMain : MonoBehaviour
     async UniTaskVoid Start()
     {
 
+
         // UniTask.Delay(TimeSpan.FromSeconds(1)).TimeoutWithoutException
 
 
@@ -562,61 +563,34 @@ public class SandboxMain : MonoBehaviour
         PlayerLoopHelper.Initialize(ref currentLoop, InjectPlayerLoopTimings.Minimum); // minimum is Update | FixedUpdate | LastPostLateUpdate
 
 
-        
-
-
-        var cancelToken = new CancellationTokenSource();
-        cancelButton.onClick.AddListener(()=>
-        {
-            cancelToken.Cancel(); // cancel from button click.
-        });
-
-        var timeoutToken = new CancellationTokenSource();
-        timeoutToken.CancelAfterSlim(TimeSpan.FromSeconds(5)); // 5sec timeout.
-
-        try
-        {
-            // combine token
-            var linkedTokenSource = CancellationTokenSource.CreateLinkedTokenSource(cancelToken.Token, timeoutToken.Token);
-
-            await UnityWebRequest.Get("http://foo").SendWebRequest().WithCancellation(linkedTokenSource.Token);
-        }
-        catch (OperationCanceledException ex)
-        {
-            if (timeoutToken.IsCancellationRequested)
-            {
-                UnityEngine.Debug.Log("Timeout.");
-            }
-            else if (cancelToken.IsCancellationRequested)
-            {
-                UnityEngine.Debug.Log("Cancel clicked.");
-            }
-            _ = ex;
-        }
-
-
-
 
         
 
+
         // TestAsync(cts.Token).Forget();
 
         okButton.onClick.AddListener(UniTask.UnityAction(async () =>
         {
-            // try timeout
+            await UniTask.WaitForEndOfFrame(this);
-            try
+            var texture = new Texture2D(Screen.width, Screen.height);
-            {
+            texture.ReadPixels(new Rect(0, 0, Screen.width, Screen.height), 0, 0);
-                //await UniTask.Delay(TimeSpan.FromSeconds(2), cancellationToken: timeoutController.Timeout(TimeSpan.FromSeconds(3)));
+            texture.Apply();
-                UnityEngine.Debug.Log("Delay Complete, Reset(and reuse).");
-                //timeoutController.Reset();
-            }
-            catch (OperationCanceledException ex)
-            {
-                //UnityEngine.Debug.Log("Timeout! FromTimeout?:" + timeoutController.IsTimeout());
-                _ = ex;
-            }
 
-            await UniTask.Yield();
+            var jpg = texture.EncodeToJPG();
+            File.WriteAllBytes("testscreencapture.jpg", jpg);
+            Debug.Log("ok?");
+
+            //var texture = ScreenCapture.CaptureScreenshotAsTexture();
+            //if (texture == null)
+            //{
+            //    Debug.Log("fail");
+            //}
+            //else
+            //{
+            //    var jpg = texture.EncodeToJPG();
+            //    File.WriteAllBytes("testscreencapture.jpg", jpg);
+            //    Debug.Log("ok?");
+            //}
         }));
 
         cancelButton.onClick.AddListener(UniTask.UnityAction(async () =>

src/UniTask/Assets/Tests/AsyncTest.cs

@@ -366,6 +366,29 @@ namespace Cysharp.Threading.TasksTests
             UniTaskScheduler.UnobservedTaskException -= action;
         });
 
+        // can not run on RuntimeUnitTestToolkit so ignore...
+        //        [UnityTest]
+        //        public IEnumerator ThrowExceptionUnawaited() => UniTask.ToCoroutine(async () =>
+        //        {
+        //            LogAssert.Expect(LogType.Exception, "Exception: MyException");
+
+        //#pragma warning disable 1998
+        //            async UniTask Throw() => throw new Exception("MyException");
+        //#pragma warning restore 1998
+
+        //#pragma warning disable 4014
+        //            Throw();
+        //#pragma warning restore 4014
+
+        //            await UniTask.DelayFrame(3);
+
+        //            GC.Collect();
+        //            GC.WaitForPendingFinalizers();
+        //            GC.Collect();
+
+        //            await UniTask.DelayFrame(1);
+        //        });
+
         async UniTask InException1()
         {
             await UniTask.Yield();