From cdc182191b3435130da4e431c388a92559bb6ceb Mon Sep 17 00:00:00 2001
From: monitor1394 <monitor1394@gmail.com>
Date: Fri, 24 Nov 2023 08:36:54 +0800
Subject: [PATCH] =?UTF-8?q?=E4=BF=AE=E5=A4=8D`Chart`=E7=9A=84`UpdateData()?=
 =?UTF-8?q?`=E6=8E=A5=E5=8F=A3=E8=BF=94=E5=9B=9E=E5=80=BC=E4=B8=8D?=
 =?UTF-8?q?=E5=87=86=E7=A1=AE=E7=9A=84=E9=97=AE=E9=A2=98?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 Documentation~/zh/changelog.md      |  1 +
 Runtime/Internal/BaseChart.Serie.cs | 78 +++++++++++++++++++++--------
 Runtime/Serie/Serie.cs              |  3 +-
 3 files changed, 58 insertions(+), 24 deletions(-)

diff --git a/Documentation~/zh/changelog.md b/Documentation~/zh/changelog.md
index 7ed0efea..3ca0e081 100644
--- a/Documentation~/zh/changelog.md
+++ b/Documentation~/zh/changelog.md
@@ -83,6 +83,7 @@ slug: /changelog
 
 日志详情：
 
+* (2023.11.24) 修复`Chart`的`UpdateData()`接口返回值不准确的问题
 * (2023.11.24) 修复`Axis`的更新数据时效果不顺畅的问题
 * (2023.11.23) 增加`Axis`的`Animation`支持动画效果
 * (2023.11.16) 取消`Legend`的`formatter`，用`LabelStyle`的代替
diff --git a/Runtime/Internal/BaseChart.Serie.cs b/Runtime/Internal/BaseChart.Serie.cs
index d17f67dc..26aaa113 100644
--- a/Runtime/Internal/BaseChart.Serie.cs
+++ b/Runtime/Internal/BaseChart.Serie.cs
@@ -454,9 +454,15 @@ namespace XCharts.Runtime
             var serie = GetSerie(serieName);
             if (serie != null)
             {
-                serie.UpdateYData(dataIndex, value);
-                RefreshPainter(serie);
-                return true;
+                if (serie.UpdateYData(dataIndex, value))
+                {
+                    RefreshPainter(serie);
+                    return true;
+                }
+                else
+                {
+                    return false;
+                }
             }
             return false;
         }
@@ -473,9 +479,15 @@ namespace XCharts.Runtime
             var serie = GetSerie(serieIndex);
             if (serie != null)
             {
-                serie.UpdateYData(dataIndex, value);
-                RefreshPainter(serie);
-                return true;
+                if (serie.UpdateYData(dataIndex, value))
+                {
+                    RefreshPainter(serie);
+                    return true;
+                }
+                else
+                {
+                    return false;
+                }
             }
             return false;
         }
@@ -491,9 +503,15 @@ namespace XCharts.Runtime
             var serie = GetSerie(serieName);
             if (serie != null)
             {
-                serie.UpdateData(dataIndex, multidimensionalData);
-                RefreshPainter(serie);
-                return true;
+                if (serie.UpdateData(dataIndex, multidimensionalData))
+                {
+                    RefreshPainter(serie);
+                    return true;
+                }
+                else
+                {
+                    return false;
+                }
             }
             return false;
         }
@@ -509,9 +527,15 @@ namespace XCharts.Runtime
             var serie = GetSerie(serieIndex);
             if (serie != null)
             {
-                serie.UpdateData(dataIndex, multidimensionalData);
-                RefreshPainter(serie);
-                return true;
+                if (serie.UpdateData(dataIndex, multidimensionalData))
+                {
+                    RefreshPainter(serie);
+                    return true;
+                }
+                else
+                {
+                    return false;
+                }
             }
             return false;
         }
@@ -528,9 +552,15 @@ namespace XCharts.Runtime
             var serie = GetSerie(serieName);
             if (serie != null)
             {
-                serie.UpdateData(dataIndex, dimension, value);
-                RefreshPainter(serie);
-                return true;
+                if (serie.UpdateData(dataIndex, dimension, value))
+                {
+                    RefreshPainter(serie);
+                    return true;
+                }
+                else
+                {
+                    return false;
+                }
             }
             return false;
         }
@@ -547,9 +577,15 @@ namespace XCharts.Runtime
             var serie = GetSerie(serieIndex);
             if (serie != null)
             {
-                serie.UpdateData(dataIndex, dimension, value);
-                RefreshPainter(serie);
-                return true;
+                if (serie.UpdateData(dataIndex, dimension, value))
+                {
+                    RefreshPainter(serie);
+                    return true;
+                }
+                else
+                {
+                    return false;
+                }
             }
             return false;
         }
@@ -566,8 +602,7 @@ namespace XCharts.Runtime
             var serie = GetSerie(serieName);
             if (serie != null)
             {
-                serie.UpdateDataName(dataIndex, dataName);
-                return true;
+                return serie.UpdateDataName(dataIndex, dataName);
             }
             return false;
         }
@@ -584,8 +619,7 @@ namespace XCharts.Runtime
             var serie = GetSerie(serieIndex);
             if (serie != null)
             {
-                serie.UpdateDataName(dataIndex, dataName);
-                return true;
+                return serie.UpdateDataName(dataIndex, dataName);
             }
             return false;
         }
diff --git a/Runtime/Serie/Serie.cs b/Runtime/Serie/Serie.cs
index a6fac691..c724c80a 100644
--- a/Runtime/Serie/Serie.cs
+++ b/Runtime/Serie/Serie.cs
@@ -1699,8 +1699,7 @@ namespace XCharts.Runtime
         /// <param name="value"></param>
         public bool UpdateYData(int index, double value)
         {
-            UpdateData(index, 1, value);
-            return true;
+            return UpdateData(index, 1, value);
         }
 
         /// <summary>